Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Added last cmd exit_code support #92

Merged
merged 1 commit into from
Sep 9, 2024
Merged

feat: Added last cmd exit_code support #92

merged 1 commit into from
Sep 9, 2024

Conversation

prsabahrami
Copy link
Collaborator

Closes #89

@prsabahrami prsabahrami changed the title Added last cmd exit_code support feat: Added last cmd exit_code support Sep 9, 2024
certik
certik approved these changes Sep 9, 2024
View reviewed changes
Copy link
Collaborator

@certik certik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine for now. Once we fix #82 we need to add tests for this also.

@certik certik merged commit 64c86d1 into main Sep 9, 2024
4 checks passed
@certik certik deleted the exit_code_support branch September 9, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hofer-Julian Hofer-Julian Hofer-Julian approved these changes

@certik certik certik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement $? to check the exit code of the last command
3 participants
@prsabahrami @certik @Hofer-Julian