fix: complex command parsing #60
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I added a few test files, just for parsing. But it doesn't quite work yet (other parsing areas are then broken). Maybe @prsabahrami has the right ideas on how to fix this . |
|
@wolfv I have implemented how I think this should be done in the branch experiment_complex_commands. Though there are brace groups used in loops which I am not yet sure how to support. You can find the commented in |
|
yes, please! the earlier the better IMO :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While
ifandforaren't working yet, they were also parsed as "simple" commands mistakenly. I tried to fix it, so that we hit the correcttodo!(...).