Implement parser for arithmetic expressions like a++
#155
Conversation
| (parentheses_expr | VARIABLE | NUMBER) ~ post_arithmetic_op | ||
| } | ||
|
|
||
|
|
||
| unary_arithmetic_op = _{ |
There was a problem hiding this comment.
Can you change unary_arithmetic_op to pre_arithmetic_op for better clarity?
crates/deno_task_shell/src/parser.rs
Outdated
| }) | ||
| } | ||
| Rule::unary_pre_arithmetic_expr => unary_pre_arithmetic_expr(first), | ||
| Rule::unary_post_arithmetic_expr => unary_post_arithmetic_expr(first), | ||
| _ => { |
There was a problem hiding this comment.
Shouldn't this result in an error given that unary_arithmetic_expr can only be one of the unary_pre_arithmetic_expr or unary_post_arithmetic_expr?
crates/deno_task_shell/src/parser.rs
Outdated
|
|
||
| fn unary_pre_arithmetic_expr(pair: Pair<Rule>) -> Result<ArithmeticPart> { | ||
| let mut inner = pair.into_inner(); | ||
| let first = inner.next().unwrap(); |
There was a problem hiding this comment.
I think it's better to replace unwraps with proper error handling.
crates/deno_task_shell/src/parser.rs
Outdated
| fn parse_unary_arithmetic_op_type(pair: Pair<Rule>) -> Result<bool> { | ||
| match pair.as_rule() { | ||
| Rule::unary_arithmetic_op => Ok(true), | ||
| Rule::post_arithmetic_op => Ok(false), | ||
| _ => Err(miette!( | ||
| "Unexpected rule in unary arithmetic operator: {:?}", | ||
| pair.as_rule() |
There was a problem hiding this comment.
This feels fairly hacky to return true of false for the type. Maybe you can try replacing this with match statement in unary_pre_arithmetic_expr?
I believe in such examples, bash raises an error while compiling. I thnik it would be better to do the same here as well. |
Armd04
changed the title
a++a++
|
@Armd04 Can you please take care of the issues on Windows? |
No description provided.