Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove some unwraps #136

Merged
merged 2 commits into from
Sep 17, 2024
Merged

chore: remove some unwraps #136

merged 2 commits into from
Sep 17, 2024

Conversation

wolfv
Copy link
Member

@wolfv wolfv commented Sep 17, 2024

No description provided.

Copy link

codecov bot commented Sep 17, 2024

Codecov Report

Attention: Patch coverage is 80.55556% with 7 lines in your changes missing coverage. Please review.

Project coverage is 63.55%. Comparing base (16b3204) to head (8f4c698).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/shell/src/commands/uname.rs 82.60% 4 Missing ⚠️
crates/shell/src/commands/which.rs 76.92% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #136      +/-   ##
==========================================
+ Coverage   62.86%   63.55%   +0.69%     
==========================================
  Files          28       28              
  Lines        2251     2261      +10     
==========================================
+ Hits         1415     1437      +22     
+ Misses        836      824      -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wolfv wolfv marked this pull request as ready for review September 17, 2024 12:03
Copy link
Collaborator

@prsabahrami prsabahrami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me.
I'll go ahead and merge it.

@prsabahrami prsabahrami merged commit 144a8de into main Sep 17, 2024
7 checks passed
@prsabahrami prsabahrami deleted the clean-unwrap branch September 17, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants