-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test crate #135
Test crate #135
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #135 +/- ##
==========================================
+ Coverage 68.27% 68.67% +0.39%
==========================================
Files 26 28 +2
Lines 2005 2062 +57
==========================================
+ Hits 1369 1416 +47
- Misses 636 646 +10 ☔ View full report in Codecov by Sentry. |
Thanks for adding this --- I think this now tests the actual shell execution in crates/tests/src/lib.rs, correct? I'll let @wolfv to review this. But we definitely need such tests (see #82). |
Yes! This tests shell's execution. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks excellent!
Had a few minor comments :)
Added a crate for testing. Created the repo on top of #124, so after merging this we can remove the other PR