-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement source
#102
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,44 @@ | ||
use anyhow::Context; | ||
use deno_task_shell::{ | ||
execute_sequential_list, AsyncCommandBehavior, ExecuteResult, ShellPipeReader, ShellPipeWriter, | ||
ShellState, | ||
}; | ||
|
||
pub async fn execute_inner(text: &str, state: ShellState) -> anyhow::Result<ExecuteResult> { | ||
let list = deno_task_shell::parser::parse(text); | ||
|
||
let stderr = ShellPipeWriter::stderr(); | ||
let stdout = ShellPipeWriter::stdout(); | ||
let stdin = ShellPipeReader::stdin(); | ||
|
||
if let Err(e) = list { | ||
anyhow::bail!("Syntax error: {}", e); | ||
} | ||
|
||
// spawn a sequential list and pipe its output to the environment | ||
let result = execute_sequential_list( | ||
list.unwrap(), | ||
state, | ||
stdin, | ||
stdout, | ||
stderr, | ||
AsyncCommandBehavior::Wait, | ||
) | ||
.await; | ||
|
||
Ok(result) | ||
} | ||
|
||
pub async fn execute(text: &str, state: &mut ShellState) -> anyhow::Result<i32> { | ||
let result = execute_inner(text, state.clone()).await?; | ||
|
||
match result { | ||
ExecuteResult::Continue(exit_code, changes, _) => { | ||
// set CWD to the last command's CWD | ||
state.apply_changes(&changes); | ||
std::env::set_current_dir(state.cwd()).context("Failed to set CWD")?; | ||
Ok(exit_code) | ||
} | ||
ExecuteResult::Exit(_, _) => Ok(0), | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wolfv Is there any reason we are bailing on syntax errors? This causes shell to exit on syntax errors in interactive mode.
Previously the error was being written to
stderr
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we might want to catch the error somewhere upstream!