Growing mesh case #600
Draft
Growing mesh case #600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 27, 2024
MakisH
reviewed
Dec 3, 2024
Comment on lines
+24
to
+25
| - A who runs first | ||
| - B who runs second |
There was a problem hiding this comment.
We so far avoid calling participants and data generic names, but try to relate to a specific physical domain and application use case. This is currently only partially described in the naming conventions.
Of course, this is fine for now (and fine for an integration test), but before merging, we should better have more descriptive names.
There was a problem hiding this comment.
They both represent the same mesh and don't model any physical behaviour.
Not sure what we would name them.
There was a problem hiding this comment.
There is a physical motivation for this scenario. We could borrow names there?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a growing mesh case.
Two solvers define the same mesh, which grows at given points in time.
Inspiration for this case is the formation of additional residue layers on the floor of an ocean over time.
@MakisH is this how you envision the separate solver folder to work?
Checklist:
changelog-entries/<PRnumber>.md.