Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify time stepping schemes and add type hints and documentation #572

Conversation

BenjaminRodenberg
Copy link
Member

@BenjaminRodenberg BenjaminRodenberg commented Sep 20, 2024

  • Remove support for monolithic case (with vector valued displacement and velocity) from time stepping schemes. This is not needed and removing this feature considerably simplifies the code.
  • Improve readability by using standard names (e.g. stages are $k_i$ in literature, not $s$).
  • Add type hints and make sure mypy works without problems.

Checklist:

  • I added a summary of any user-facing changes (compared to the last release) in the changelog-entries/<PRnumber>.md. no user-facing changes
  • I will remember to squash-and-merge, providing a useful summary of the changes of this PR.

@BenjaminRodenberg BenjaminRodenberg merged commit 9d99538 into precice:develop Oct 19, 2024
1 check passed
@BenjaminRodenberg BenjaminRodenberg deleted the simplify-and-document-solver branch October 19, 2024 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants