Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tutorial: Partitioned multiphase pipe flow #418

Merged
merged 18 commits into from
Jan 24, 2024
Merged

Conversation

thesamriel
Copy link
Contributor

@thesamriel thesamriel commented Nov 30, 2023

This PR adds a tutorial case for the OpenFOAM adapter and its Fluid-Fluid coupling module.

The case consists of a multiphase flow through a 2-D pipe where one half of the inlet provides air, the other half water.
This test case is very basic and unphysical in order to avoid any fluid circulations that usually occur for multiphase flows. Gravity is set to 0.

This case should be run with the alpha-coupling branch of the OpenFOAM adapter. See precice/openfoam-adapter#308

The preCICE files currently still contain (commented out) the coupling of the flux phi. This is to test the coupling of phi from above mentioned PR. However, it serves no purpose to this tutorial and should probably be removed before merging.

I will look into the following ToDos, once we decide if and how we want to keep this tutorial.
TODO:

  • Change folder name
  • Add Readme
  • Remove coupling of phi?
  • Check all scripts etc

@thesamriel thesamriel changed the title Interfoam pipe Add Tutorial: Partitioned multiphase pipe flow Nov 30, 2023
@thesamriel thesamriel requested a review from MakisH November 30, 2023 18:07
Copy link
Member

@MakisH MakisH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the PR! I have not yet tested it, but it already looks very clean. I only have some tiny comments.

I will look into the following ToDos, once we decide if and how we want to keep this tutorial.

Well, we have no other case demonstrating two-phase flow, we should keep it. Also as a test case in the system tests. Feel free to mention clearly in the README that this is not a physical case, it has limitations, and it mainly meant as a basic testcase.

Change folder name

partitioned-pipe-two-phase would be good.

Remove coupling of phi?

I am not sure, but some documentation would not harm. If phi is not used at all, it would be confusing to keep it, so let's remove it.

interfoam-pipe/README.md Outdated Show resolved Hide resolved
interfoam-pipe/fluid1-openfoam/0.orig/U Outdated Show resolved Hide resolved
interfoam-pipe/fluid1-openfoam/0.orig/alpha.water Outdated Show resolved Hide resolved
interfoam-pipe/precice-config.xml Outdated Show resolved Hide resolved
interfoam-pipe/precice-config.xml Outdated Show resolved Hide resolved
interfoam-pipe/fluid1-openfoam/system/sampling Outdated Show resolved Hide resolved
interfoam-pipe/fluid2-openfoam/0.orig/p_rgh Outdated Show resolved Hide resolved
interfoam-pipe/fluid2-openfoam/constant/g Outdated Show resolved Hide resolved
@MakisH
Copy link
Member

MakisH commented Jan 19, 2024

@thesamriel I can take this over, just let me know if you have any inputs on my previous suggestions.

@thesamriel
Copy link
Contributor Author

@thesamriel I can take this over, just let me know if you have any inputs on my previous suggestions.

I updated the files according to your suggestions. The only major thing left is the coupling of phi. I left the code in there for you to potentially try it out. However, it is not relevant to this tutorial and should be deleted before merging.

Copy link
Member

@MakisH MakisH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of tiny wrinkles to iron. Thanks a lot, it's almost merged!

partitioned-pipe-two-phase/README.md Outdated Show resolved Hide resolved
partitioned-pipe-two-phase/monolithic/clean.sh Outdated Show resolved Hide resolved
interfoam-pipe/precice-config.xml Outdated Show resolved Hide resolved
interfoam-pipe/fluid2-openfoam/0.orig/p_rgh Outdated Show resolved Hide resolved
@MakisH MakisH marked this pull request as ready for review January 23, 2024 17:35
Copy link
Member

@MakisH MakisH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, thank you!
I think this is now ready to merge, as soon as precice/openfoam-adapter#308 is merged.

The notes in the README regarding versions will be updated separately #446.

@MakisH MakisH self-assigned this Jan 24, 2024
@MakisH MakisH merged commit d39627c into develop Jan 24, 2024
3 checks passed
@MakisH MakisH deleted the interfoam-pipe branch January 24, 2024 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants