Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve install error messages #223

Merged
merged 2 commits into from
Oct 23, 2024
Merged

Conversation

fsimonis
Copy link
Member

This PR adds a more helpful error message when the python bindings cannot find preCICE using pkg-config.
It also silences the NumPy warning to prevent it from distracting from the actual problem.

@fsimonis fsimonis force-pushed the improve-install-error-messages branch from 5abf931 to de5b21a Compare October 10, 2024 13:32
@uekerman uekerman requested a review from IshaanDesai October 23, 2024 06:25
Copy link
Member

@IshaanDesai IshaanDesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@IshaanDesai IshaanDesai merged commit dc7e520 into develop Oct 23, 2024
20 checks passed
@IshaanDesai IshaanDesai deleted the improve-install-error-messages branch October 23, 2024 11:42
@precice-bot
Copy link

This pull request has been mentioned on preCICE Forum on Discourse. There might be relevant details there:

https://precice.discourse.group/t/error-when-installing-python-bindings/2147/4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants