Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove spack testing #221

Merged
merged 3 commits into from
Nov 4, 2024
Merged

Remove spack testing #221

merged 3 commits into from
Nov 4, 2024

Conversation

fsimonis
Copy link
Member

@fsimonis fsimonis commented Sep 4, 2024 •
edited
Loading

This PR removes the spack-related tests and documentation.

Testing the spack package is now an additional optional step in the Release Guide.

Closes #220

@fsimonis fsimonis requested review from IshaanDesai and BenjaminRodenberg and removed request for IshaanDesai September 4, 2024 13:52
@fsimonis fsimonis self-assigned this Sep 4, 2024
@BenjaminRodenberg BenjaminRodenberg mentioned this pull request Sep 4, 2024
Merged
BenjaminRodenberg
BenjaminRodenberg requested changes Sep 4, 2024
View reviewed changes
Copy link
Member

@BenjaminRodenberg BenjaminRodenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cleaning this up makes a lot of sense. But I'm still not sure how the new process for updating the spack package will look like.

I think you also accidentally deleted some tests that we will still need.

.github/workflows/build-and-test.yml Outdated Show resolved Hide resolved
.github/workflows/build-and-test.yml Outdated Show resolved Hide resolved
.github/workflows/build-and-test.yml Outdated Show resolved Hide resolved
.github/workflows/build-and-test.yml Show resolved Hide resolved
.github/workflows/build-env.yml Outdated Show resolved Hide resolved
.github/workflows/build-spack.yml Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
docs/ReleaseGuide.md Show resolved Hide resolved
spack/repo/packages/py-pyprecice/package.py Outdated Show resolved Hide resolved
@fsimonis fsimonis force-pushed the remove-spack-testing branch from 4778351 to fd742db Compare September 4, 2024 14:41
@fsimonis fsimonis changed the title Remove spack and setup.py testing Remove spack testing Sep 4, 2024
@fsimonis
Copy link
Member Author

fsimonis commented Sep 4, 2024

I updated this PR to only remove spack-specific things.

@fsimonis fsimonis force-pushed the remove-spack-testing branch from fd742db to 4cee6f4 Compare September 4, 2024 14:48
BenjaminRodenberg
BenjaminRodenberg approved these changes Sep 5, 2024
View reviewed changes
Copy link
Member

@BenjaminRodenberg BenjaminRodenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍 Let's 💥 the spack tests.

spack/repo/packages/py-pyprecice/package.py Outdated Show resolved Hide resolved
@fsimonis fsimonis merged commit 2cb1fee into develop Nov 4, 2024
14 checks passed
@fsimonis fsimonis deleted the remove-spack-testing branch November 4, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IshaanDesai IshaanDesai IshaanDesai approved these changes

@BenjaminRodenberg BenjaminRodenberg BenjaminRodenberg approved these changes

Assignees

@fsimonis fsimonis

Labels
compatibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Spack testing obsolete
3 participants
@fsimonis @BenjaminRodenberg @IshaanDesai