Release v3.0.0.0 #190
Merged
Release v3.0.0.0 #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use experimental API. Related to precice/precice#1187. * Add missing API functions and fix tests. * Remove API mathods that are removed in preCICE v3.0.0.
…ta(...) (#157) Co-authored-by: Kanishk Bhatia <[email protected]>
* [WIP] Make bindings compatible with precice:develop * Updating solverdummy and checkpoint related API functions * Removing unnecessary semicolons * Add correct arguments to functions in SolverInterface.cpp * Add size as input argument to mesh connectivity API functions for testing * Remove incorrect bracket from deleted namespace * [WIP] Using same names for input arguments of API functions * correct return type for setMeshEdge in SolverInterface.cpp * void function setMeshEdge should not return anything * Adapted compatibility-precice-dev branch (#162) * Use precice-setup-action * Modify solverdummy Action * Use precice-setup action appropriately in steps * Change apt-get commands to use sudo in build and test workflows * Change rm -rf commands to use sudo in build and test workflows * Remove get_mesh_vertices and get_mesh_vertex_ids_from_positions * Use precice-setup-action in Spack workflow * Simplify testing. * Remove sudo. * Use benjaminrodenberg/precice:develop * Try with root user. * Update solverdummies test. * Fix solverdummy. --------- Co-authored-by: Ishaan Desai <[email protected]> Co-authored-by: Timo-Schrader <[email protected]>
* Use develop release of dockerfile * Don't create user User already exists in benjaminrodenberg/precice:develop
* [WIP] Make bindings compatible with precice:develop * Updating solverdummy and checkpoint related API functions * Removing unnecessary semicolons * Add correct arguments to functions in SolverInterface.cpp * Add size as input argument to mesh connectivity API functions for testing * Remove incorrect bracket from deleted namespace * [WIP] Using same names for input arguments of API functions * correct return type for setMeshEdge in SolverInterface.cpp * void function setMeshEdge should not return anything * Adapted compatibility-precice-dev branch (#162) * Use precice-setup-action * Modify solverdummy Action * Use precice-setup action appropriately in steps * Change apt-get commands to use sudo in build and test workflows * Change rm -rf commands to use sudo in build and test workflows * Remove get_mesh_vertices and get_mesh_vertex_ids_from_positions * Use precice-setup-action in Spack workflow * Use main branch of setup-precice-action * Use container precice/precice:develop * Remove sudo from build-and-test.yml * Use C++17 in setup.py * Install sudo in workflows and use it to remove lock file * Use user: root in setup_test workflow * Remove sudo from the command to remove lock files --------- Co-authored-by: Timo-Schrader <[email protected]>
* Change bindings to use names of meshes and data instead of IDs * Formatting * Add correct input arguments to requires_gradient_data_for * Remove incorrect user keyword * Correct typo * Converting Python string to cython bytes and then passing over as string_view to C++ API * Add overloaded constructors for string_view to handle Python strings and nullptr * Cast cdef bytes to const char* before handing over to C++ API * Try options: user --root in build-and-test Actions * Move options: user --root line outside of steps in build-and-test Actions * Add su precice command to switch to user precice * Add su root to setup test workflow * Use su precice in setup test workflow * Remove the removal of lock files * Add sudo to test which runs on ubuntu-latest and remove old API functions from .pxd file * Include vector library in test/SolverInterface.cpp * Modify test/SolverInterface.cpp to what it is in precice:precice * Add includes for vector and string_view in test/SolverInterface.cpp * Further corrections to test/SolverInterface.cpp * Remove su root from setup_install workflow * Changing iterator i from int to std::size_t * Export LD_LIBRARY_PATH in setup_install workflow * Copy precice/src/precice/Tooling.hpp for mock testing * Copy precice/src/precice/Tooling.cpp for mock testing * Add Tooling.hpp header in fake SolverInterface.cpp for testing * Typo * Add fake_version to SolverInterface.cpp * Define fake_version before using it * Add weird b in front of string of fake_version * Set LD_LIBRARY_PATH before running anything related to the bindings * Remove su root and su precice to see if it is really necessary * Delete and not just comment su root and su precice to see if it is really necessary * Remove fake_mesh_id and add fake_mesh_name in bindings test * Remove all instances of fake_mesh_id#
… building Docker image
…in the solverdummy
* Lint markdown files and update correspondingly. * Minor update.
* Rename SolverInterface to Participant and remove old API functions * Further changes for v3 compatibility * Update to new API. Tests except for gradient mapping are all working. * Fix for empty mesh. * Add missing API functions and small corrections * Fix building issue * Reformating test/Participant.cpp * Fixing test_write_block_scalar_gradient_data_single_float * Fix gradient tests * Import getVersionInformation in the correct way * initialize() does not return anything * Remove merge conflict tag * Mistake in resolving merge conflicts --------- Co-authored-by: Benjamin Rodenberg <[email protected]>
Release v3.0.0.0dev0
…es_and_ids to get_mesh_vertices_and_coordinates
* - modify args to fit to systemtest - make the manual triggering more useful - move latest tag to last master * bash string handling... Fun stuff * sprinkle in some " * adding some "debug" ouptut * Update .github/workflows/build-docker.yml Co-authored-by: Gerasimos Chourdakis <[email protected]> * Update .github/workflows/build-docker.yml Co-authored-by: Gerasimos Chourdakis <[email protected]> --------- Co-authored-by: Valentin Seitz <[email protected]> Co-authored-by: Gerasimos Chourdakis <[email protected]>
Additionally, assuming subcycling is used, I would even consider calling get_max_time_step_size directly before advance an anti-pattern.
BenjaminRodenberg
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This release is necessary to make the bindings compatible with the recently released preCICE v3.0.0. The release notes describe the changes in details.