Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Cython as dependency required during installation #177

Merged
merged 2 commits into from
Feb 5, 2024

Conversation

IshaanDesai
Copy link
Member

Possibly resolves #176

@IshaanDesai IshaanDesai self-assigned this May 10, 2023
Copy link
Member

@BenjaminRodenberg BenjaminRodenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot see a (documented) reason speaking against adding it and if it is causing trouble without, we obviously need it.

@IshaanDesai IshaanDesai removed the request for review from fsimonis February 5, 2024 11:16
@IshaanDesai IshaanDesai merged commit c4d9786 into develop Feb 5, 2024
18 checks passed
@IshaanDesai IshaanDesai deleted the cython-dependency branch February 5, 2024 11:17
BenjaminRodenberg added a commit that referenced this pull request Dec 5, 2024
* Lint markdown files and update files correspondingly. (#180)
* Add Cython as dependency required during installation (#177)
* Adapt Docker workflow according to new system tests design (#186)
  - modify args to fit to systemtest
  - make the manual triggering more useful
  - move latest tag to last master
* bash string handling... Fun stuff
* sprinkle in some "
* adding some "debug" ouptut
* Update .github/workflows/build-docker.yml
* Require setuptools>=61 (#207)
* Restrict to numpy < 2 and setuptools < 72 for better compatibiltiy with CI pipeline (#213)
* Simplify setup.py w.r.t noisy warning (always shown when building with spack).
* Use Ubuntu 24.04.
* Explicitly specify docker image tags in CI.
* use spack base image precice/ci-spack-pyprecice-deps-2404:2.5.1.0
* use precice base image precice/precice:2.5.1
* Add entry in changelog.
* Fix spack workflow for 2.5.1.0.
* Add branch for release candidate of 2.5.1.0
* Update build dependencies for release candidate
* Use PyPI token instead of username and password in the package publishing action

---------

Co-authored-by: Ishaan Desai <[email protected]>
Co-authored-by: valentin-seitz <[email protected]>
Co-authored-by: Valentin Seitz <[email protected]>
Co-authored-by: Gerasimos Chourdakis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pip install --user pyprecice - fails Cython dependency
2 participants