Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix layout semantics #478

Merged
merged 1 commit into from
Dec 12, 2024
Merged

Fix layout semantics #478

merged 1 commit into from
Dec 12, 2024

Conversation

fsimonis
Copy link
Member

@fsimonis fsimonis commented Dec 12, 2024

This PR fixes the landmark semantics of the HTML layout using the Accessibility insights for web inspectors.

  • sidebar and table of content navigations are now correctly wrapped in nav tags and use aria-label to describe which label they are
  • the main content does not contain elements which are repeated over the website
  • the website footer is outside of the main tag
  • the sidebar is outside of the main tag
  • the news banner is a <aside role="banner"> and outside the main tag
  • the edit section is wrapped in an aside
Doc Home
Old old doc old home
New new doc new home

@fsimonis fsimonis self-assigned this Dec 12, 2024
@fsimonis fsimonis force-pushed the fix-layout-semantics branch from c470caa to 3f07a26 Compare December 12, 2024 19:12
Copy link
Member

@MakisH MakisH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds like a good change that should not harm anything.
I only had a quick look, and I do not have enough expertise in web development to judge the technicalities.

@fsimonis fsimonis merged commit a501a3f into master Dec 12, 2024
2 checks passed
@fsimonis fsimonis deleted the fix-layout-semantics branch December 12, 2024 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants