Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Python installation instructions in community-training.md #454

Merged
merged 2 commits into from
Dec 11, 2024

Conversation

MakisH
Copy link
Member

@MakisH MakisH commented Sep 16, 2024

There are several more places on the website and our documentation in general that need updating (including the Python bindings), this is only focusing on the training page.

Note: I am wondering if the suggestion to create the venv as .venv conflicts with the run scripts that also call python -m venv .venv (and later try to re-source the venv). I can eventually try this.

@MakisH MakisH self-assigned this Sep 16, 2024
@fsimonis fsimonis self-requested a review September 18, 2024 09:08
Add hint for venv

co-authored-by @fsimonis
@MakisH
Copy link
Member Author

MakisH commented Dec 11, 2024

I tried following the instructions for the CHT part of the course (Nutils), and having a venv already activated does not conflict: the run.sh script of solid-nutils creates and activates a new venv in a local directory .venv and re-installs the requirements, using cached packages.

Creating the venv directly in the place where the run script automatically creates a new venv does not matter as well (even if this is not a realistic use case), as the directory is not overwritten, and no error is thrown.

If anything, we might need to improve the tutorials assumptions.

@MakisH MakisH merged commit 8165921 into master Dec 11, 2024
2 checks passed
@MakisH MakisH deleted the MakisH-python-venv branch December 11, 2024 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants