Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use setup-openfoam action in workflows #338

Merged
merged 3 commits into from
Aug 22, 2024

Conversation

gerlero
Copy link
Contributor

@gerlero gerlero commented Aug 19, 2024

Switches to the setup-openfoam action (disclaimer: I made the action) for installing OpenFOAM in the build workflows.

I hope you can agree that this simplifies the workflows quite a bit.

TODO list:

  • I updated the documentation in docs/ -> N/A
  • I added a changelog entry in changelog-entries/ (create directory if missing)

@gerlero
Copy link
Contributor Author

gerlero commented Aug 20, 2024

I've updated the changelog directly, but now I'm not sure that's the correct workflow. Also, I assume docs changes are not needed for this.

Copy link
Member

@davidscn davidscn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a simplification, let's see what the CI says.

CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Member

@MakisH MakisH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a very useful addition, thank you very much @gerlero!

On a side note, this would make for a nice presentation at the OpenFOAM RSE group: https://wiki.openfoam.com/Research_Software_Engineering_Special_Interest_Group

Docs changes are indeed not needed. For the changelog, see what David wrote (or I can apply the change directly).

.github/workflows/build.yml Show resolved Hide resolved
.github/workflows/build-custom.yml Show resolved Hide resolved
@gerlero
Copy link
Contributor Author

gerlero commented Aug 21, 2024

On a side note, this would make for a nice presentation at the OpenFOAM RSE group: https://wiki.openfoam.com/Research_Software_Engineering_Special_Interest_Group

Sure, no problem. I've been aware of those meetings for a couple of months but couldn't make it to the last one. The reason I'm making this stuff is that I'm running OpenFOAM-based CIs myself for a few projects, so our interests should overlap quite a bit. I'll make sure to attend the next one.

@MakisH MakisH requested review from davidscn and MakisH August 22, 2024 10:59
@MakisH MakisH self-assigned this Aug 22, 2024
@MakisH MakisH merged commit de988ea into precice:develop Aug 22, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants