-
-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use setup-openfoam action in workflows #338
Conversation
I've updated the changelog directly, but now I'm not sure that's the correct workflow. Also, I assume docs changes are not needed for this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like a simplification, let's see what the CI says.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a very useful addition, thank you very much @gerlero!
On a side note, this would make for a nice presentation at the OpenFOAM RSE group: https://wiki.openfoam.com/Research_Software_Engineering_Special_Interest_Group
Docs changes are indeed not needed. For the changelog, see what David wrote (or I can apply the change directly).
Sure, no problem. I've been aware of those meetings for a couple of months but couldn't make it to the last one. The reason I'm making this stuff is that I'm running OpenFOAM-based CIs myself for a few projects, so our interests should overlap quite a bit. I'll make sure to attend the next one. |
Switches to the setup-openfoam action (disclaimer: I made the action) for installing OpenFOAM in the build workflows.
I hope you can agree that this simplifies the workflows quite a bit.
TODO list:
docs/
-> N/Achangelog-entries/
(create directory if missing)