Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document the type of gradients we support #334

Merged
merged 1 commit into from
Jun 27, 2024
Merged

Document the type of gradients we support #334

merged 1 commit into from
Jun 27, 2024

Conversation

MakisH
Copy link
Member

@MakisH MakisH commented Jun 26, 2024 •
edited
Loading

Closes precice/tutorials#543

TODO list:

  • I updated the documentation in docs/
  • I added a changelog entry in changelog-entries/ (create directory if missing) -> not needed

@MakisH MakisH requested a review from uekerman June 26, 2024 15:18
@MakisH MakisH self-assigned this Jun 26, 2024
@MakisH MakisH marked this pull request as ready for review June 27, 2024 05:45
MakisH
MakisH commented Jun 27, 2024
View reviewed changes
Copy link
Member Author

@MakisH MakisH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed with @uekerman, this is already ok.

@MakisH MakisH merged commit 374a016 into precice:develop Jun 27, 2024
3 checks passed
@MakisH MakisH deleted the doc-gradients branch June 27, 2024 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uekerman uekerman Awaiting requested review from uekerman

Assignees

@MakisH MakisH

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Gradients: Surface-normal (scalars) vs complete (vector)
1 participant
@MakisH