Remove unnecessary timestepPrecice_
#322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MakisH
approved these changes
Mar 10, 2024
I think it was only unnecessarily complicated. But it's always hard to pin bugs down if subcycling is involved, so I cannot promise I have not accidentally fixed a bug 😏 Therefore I also changed this to have a version of the code where I'm quite optimistic it's not buggy. |
|
Just for the future reader: This was originally implemented with a separate variable (for preCICE v1) just to reduce the function calls and avoid duplication. No other particular intention here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pure refactoring to simplify the code if determining the time step size.