Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added a test workflow #309

Merged
merged 14 commits into from
Mar 13, 2024
Merged

Added a test workflow #309

merged 14 commits into from
Mar 13, 2024

Conversation

valentin-seitz
Copy link
Member

No description provided.

@valentin-seitz valentin-seitz marked this pull request as ready for review December 16, 2023 17:40
@valentin-seitz valentin-seitz marked this pull request as draft December 16, 2023 17:45
MakisH
MakisH reviewed Dec 17, 2023
View reviewed changes
Copy link
Member

@MakisH MakisH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Seems to be very small and elegant. How can we test it? Can you please add more details in the description?

@valentin-seitz valentin-seitz self-assigned this Dec 21, 2023
MakisH
MakisH approved these changes Dec 21, 2023
View reviewed changes
Copy link
Member

@MakisH MakisH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving to test the event trigger.

We generally don't really like that it would only start once the whole PR is approved, but that's maybe fine since this is only the system tests.

@valentin-seitz valentin-seitz requested a review from MakisH January 8, 2024 14:31
@MakisH
Copy link
Member

MakisH commented Mar 4, 2024

@valentin-seitz is this ready to merge?

@MakisH MakisH marked this pull request as ready for review March 13, 2024 08:13
@MakisH MakisH force-pushed the add-tests-workflow branch 2 times, most recently from 48563e9 to 48b177c Compare March 13, 2024 12:00
@MakisH MakisH force-pushed the add-tests-workflow branch from 48b177c to 0e91542 Compare March 13, 2024 12:02
@MakisH
Copy link
Member

MakisH commented Mar 13, 2024

The system tests are now triggered by adding (or removing and re-adding) the trigger-system-tests label to the pull request.

They use:

  • preCICE v3.0.0
  • OpenFOAM v2306
  • latest develop of tutorials
  • HEAD of the pull request

They currently fail, as expected, with:

CRITICAL: Fieldcompare returned non zero exit code, therefore Flow over heated plate (fluid-openfoam, solid-openfoam) failed

This is something to fix in the tutorials repository.

@MakisH MakisH merged commit ac79b78 into develop Mar 13, 2024
6 checks passed
@MakisH MakisH deleted the add-tests-workflow branch March 13, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MakisH MakisH MakisH approved these changes

Assignees

@valentin-seitz valentin-seitz

Labels
trigger-system-tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@valentin-seitz @MakisH