-
-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port the adapter to preCICE v3 #285
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice, thanks for all the effort!
Can we now make this PR the central/single PR that ports the adapter to v3? This means changing the title and description. It is currently a bit lost like this.
The only thing missing seems to be the connectivity: (#258)
Interface.C: In member function ‘void preciceAdapter::Interface::configureMesh(const Foam::fvMesh&, const string&, const string&)’:
Interface.C:306:26: error: ‘class precice::Participant’ has no member named ‘getMeshVertexIDsFromPositions’
306 | precice_.getMeshVertexIDsFromPositions(meshID_, faceField.size() * (triaPerQuad * nodesPerTria), triCoords, triVertIDs);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Interface.C:313:30: error: ‘class precice::Participant’ has no member named ‘setMeshTriangleWithEdges’; did you mean ‘setMeshTriangles’?
313 | precice_.setMeshTriangleWithEdges(meshID_, triVertIDs[facei * nodesPerTria], triVertIDs[facei * nodesPerTria + 1], triVertIDs[facei * nodesPerTria + 2]);
| ^~~~~~~~~~~~~~~~~~~~~~~~
| setMeshTriangles
Since other projects depend on porting the OpenFOAM adapter to develop (@ezonta, @tirgendetwas), we can also temporarily work around the issue by removing the calls to the removed methods (which means that the tutorials relying on nearest-projection mapping would give different results). The |
Yes. Right now, the nearest-projection configuration in the adapter has a mediocre usability at a debatable feature gain, so I would consider it rather low priority. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR includes most of the changes required to port the adapter to use the upcoming preCICE v3.
Depends on #266 and implements precice/precice#1471
Follow-up regarding connectivity: #297.
Related to #235.
TODO list:
docs/
changelog-entries/
(create directory if missing)