Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v1.2.0 #257

Merged
merged 31 commits into from
Nov 18, 2022
Merged

Release v1.2.0 #257

merged 31 commits into from
Nov 18, 2022

Conversation

MakisH
Copy link
Member

@MakisH MakisH commented Nov 14, 2022

This is a small feature release, which mainly enables a few additional features:

  • Restarting from an undeformed state in FSI
  • Using the solid solver of solids4foam
  • Using the RBFMeshMotionSolver of solids4foam, as well as other mesh motion solvers that are not based on pointDisplacement
  • 2D axisymmetric cases

Note that previously the adapter was always building with four threads by default. We now removed that strange assumption and documented the WM_NCOMPPROCS of OpenFOAM, instead.

As always, there are also a few small improvements here and there, as well as more documentation. See the CHANGELOG.md for more.

This release includes code contributions and reviews by the preCICE team (@MakisH, @davidscn, @fsimonis), as well as code contributions by @solids4foam.

Release checklist

Copy this template to the release pull request description.

Update workflows

  • .github/workflows/build.yml and .github/workflows/install-dependencies.sh: Update the OpenFOAM and preCICE versions, if needed.
  • build-custom.yml: Add any new OpenFOAM versions and update the default preCICE version, if needed.

Prepare branches

  • Merge master to develop, if needed
  • Open a pull request from develop to master.
    • We don't use release branches, unless there are changes we don't want to release, potentially when preparing a major release.
  • Run and fix all workflows

Test

  • Run and check flow-over-heated-plate OpenFOAM-OpenFOAM
  • Run and check quickstart
  • Run and check perpendicular-flap OpenFOAM-deal.II
  • Run and check elastic-tube-3d OpenFOAM-CalculiX (at least the first few time windows)
  • Run and check partitioned-pipe sonicLiquidFoam-sonicLiquidFoam
  • Run and check heat-exchanger OpenFOAM-CalculiX-OpenFOAM (at least the first three time windows)

Until we get automated system tests again, run all the tests manually.

Preparing the Changelog

  • Copy all the changelog entries into CHANGELOG.md
  • Delete changelog-entries/
  • Mark issues and pull requests that made it to this milestone.
  • Collect a list of contributors to acknowledge (particularly non-code contributions that are not easily visible on GitHub).
  • Draft and discuss release notes

Bump the version

  • Decide on the version using the versioning strategy documented in the user docs (see page "Get the OpenFOAM adapter")
  • Bump the version in CHANGELOG.md
  • Bump the version in Adapter.C (removing the + unreleased changes part).
  • Make the version bump commit the last commit before merging.

Merge

  • Review pull request
  • Merge pull request (not squash)

Prepare version-specific branches

Overview of branches:

master <-- OpenFOAM4 <-- OpenFOAM5 <-- OpenFOAM6 <-- OpenFOAM7 <-- ... <-- OpenFOAMdev
^-- develop     ^-- OpenFOAMv1806

Release

  • Create a Release on GitHub
  • Download an archive of the repository (i.e., no .git/ or .gitignore) for each version and attach to the release. Use the link https://github.com/precice/openfoam-adapter/archive/refs/heads/BRANCH.tar.gz (substitute BRANCH). Rename the folder in each archive to reflect the name of the archive.
    • branch master: archive openfoam-adapter_v1.0.0_OpenFOAMv1812-v2206-newer.tar.gz (adjust v2206 to the latest supported, and v1.0.0 to the actual version)
    • branch OpenFOAM4: archive openfoam-adapter_v1.0.0_OpenFOAM4_5_v1806.tar.gz
    • branch OpenFOAM6: archive openfoam-adapter_v1.0.0_OpenFOAM6_experimental.tar.gz
    • branch OpenFOAM7: archive openfoam-adapter_v1.0.0_OpenFOAM7_experimental.tar.gz
    • branch OpenFOAM8: archive openfoam-adapter_v1.0.0_OpenFOAM8_experimental.tar.gz

Post-release

  • Merge back from master to develop. No PR is needed for that.
  • Modify the adapter version message to Loaded the OpenFOAM-preCICE adapter v1.0.0 + unreleased changes.
  • Update workflows in the tutorials repository, if needed (e.g., OpenFOAM version)
  • Update external documentation (tutorials, website), e.g., regarding the adapter or OpenFOAM version.
    • Quickstart
  • Update the VM provisioning scripts, if needed (e.g., OpenFOAM version)
  • Update this release checklist (tools/release_pull_request_template.md)
  • Advertise and celebrate! 🎉 🍻

MakisH and others added 24 commits February 8, 2022 19:32
… solver (#236)

Co-authored-by: Philip Cardiff <[email protected]>
Co-authored-by: Gerasimos Chourdakis <[email protected]>
* Inform user about WM_NCOMPPROCS, remove -j flag
* Document WM_NCOMPPROCS
* Add changelog entry
* Add default value for unset WM_NCOMPPROCS

Co-authored-by: David Schneider <[email protected]>
To circumvent wrong font issues
* Implement a checkpoint reset functionality
* Add more comments in the code as suggested in the review
* Add documentation for the new option
* Rename variable to restartFromDeformed
* Restrict option to fluid solvers

Co-authored-by: Gerasimos Chourdakis <[email protected]>
@MakisH MakisH added this to the v1.2.0 milestone Nov 14, 2022
@MakisH MakisH self-assigned this Nov 14, 2022
@MakisH MakisH marked this pull request as ready for review November 16, 2022 16:34
@MakisH MakisH merged commit 7afeaed into master Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants