Update changelog for version v1.0.1 #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MakisH
reviewed
Jan 25, 2022
| @@ -10,7 +10,7 @@ preciceAdapter::Adapter::Adapter(const Time& runTime, const fvMesh& mesh) | |||
| : runTime_(runTime), | |||
| mesh_(mesh) | |||
| { | |||
| adapterInfo("Loaded the OpenFOAM-preCICE adapter - unreleased version.", "info"); | |||
| adapterInfo("Loaded the OpenFOAM-preCICE adapter - v1.0.1.", "info"); | |||
There was a problem hiding this comment.
Discussion between @uekerman, @davidscn, and me:
- Versioning strategy writes:
-
Minor: new features (nearest-projection mapping, fluid-fluid coupling, ...). New tutorials may need this new version.
-
Bugfix / revision: small nice-to-have updates or bugfixes. The same tutorials run with any revision.
- With this in mind, bugfix is ok.
-
- The additional location checks is an important safety feature we should emphasize -> could go to a minor release.
- In preCICE, we really use "bugfix" as "this is fixing something that was previously wrong and needs to be released immediately". This typically results in a cherry-pick. With a bugfix release, we want to be 100% sure that we don't introduce new bugs -> because we had updates for OpenFOAM v2112 (that may be breaking for some older releases or have other side effects), let's to minor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...as part of the release procedure.