Add C++ Implementation of precice-aste-join #156
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidscn
reviewed
Dec 19, 2022
| po::store(parse_command_line(argc, argv, desc), vm); | ||
|
|
||
| if (vm.count("help")) { | ||
| std::cout << desc << std::endl; |
There was a problem hiding this comment.
As you already mentioned in your comment, we should probably include the ASTE logger here. Should be easy to use anyway.
Comment on lines
+46
to
+48
| } catch (nlohmann::detail::type_error &) { | ||
| std::cerr << "Error while parsing recovery file \"size\" is missing"; | ||
| std::exit(EXIT_FAILURE); |
There was a problem hiding this comment.
I guess this is an unintentional duplication of the catch above?
Comment on lines
+56
to
+58
| } catch (nlohmann::detail::type_error &) { | ||
| std::cerr << "Error while parsing recovery file \"cell_types\" is missing"; | ||
| std::exit(EXIT_FAILURE); |
There was a problem hiding this comment.
I guess this is an unintentional duplication of the catch above?
Comment on lines
+33
to
+38
| /** | ||
| * @brief Count the number of partitioned mesh files for given prefix | ||
| * | ||
| * @param prefix | ||
| * @return size_t | ||
| */ |
There was a problem hiding this comment.
Same as above, I won't comment all the comments
| return joinedMesh; | ||
| } | ||
|
|
||
| auto recoveryMerge(const std::string &prefix, std::size_t numparts, int size, const std::vector<int> &cellTypes, const std::vector<std::vector<int>> &cells) -> vtkSmartPointer<vtkUnstructuredGrid> |
There was a problem hiding this comment.
Looks like there is quite a lot of duplication between the partitionwiseMerge and the recoveryMerge. I would expect that the one is a subroutine of the other.
I would propose to first add tests and afterwards refactor here.
Co-authored-by: David Schneider <[email protected]>
Co-authored-by: David Schneider <[email protected]>
Co-authored-by: David Schneider <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main changes of this PR
Add an C++ implementation of precice-aste-join
Due to many loops and copy operations, Python implementation is considerably slow for large meshes. This C++ implementation provides 4-8 times faster merge operations than the Python version.
What is missing?
Author's checklist
pre-commithook and usedpre-commit run --allto apply all available hooks.docs/README.md.precice/tutorials/aste-turbine.