Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Connatix adapter: Add viewability field #4168

Open
wants to merge 44 commits into
base: master
Choose a base branch
from
Open

Connatix adapter: Add viewability field #4168

wants to merge 44 commits into from
+14 −5

Conversation

monicaroxanabota
Copy link

@monicaroxanabota monicaroxanabota commented Jan 20, 2025 •
edited
Loading

Add ViewabilityPercentage for connatix adaptor

@patrickszeleczki
add models for adapter
395401d
@patrickszeleczki
add adapter
714bfe7
@patrickszeleczki
add bidder info
51f4e61
@patrickszeleczki
add bidder params along with tests
215430b
@patrickszeleczki
add bid request tests
185aeaa
@patrickszeleczki
Merge branch 'prebid:master' into add-cnx-adapter
b377051
@patrickszeleczki
fix endpoint
5ed6570
@patrickszeleczki
add validation for device ip
8c03223
@patrickszeleczki
add the maintainer email
b61d5ff
@patrickszeleczki
add user sync support
1c5bcac
@patrickszeleczki
fix user sync config
2162440
@patrickszeleczki
Merge pull request #1 from Connatix/add-cnx-adapter
5144c53 
New Adapter: Connatix
@patrickszeleczki
Merge branch 'prebid:master' into master
08242be
@patrickszeleczki
Merge branch 'prebid:master' into master
55ec262
@patrickszeleczki
fix content type header
b57a08a
@patrickszeleczki
Merge pull request #2 from Connatix/add-cnx-adapter
28ed966 
Fix content type header
@patrickszeleczki
include ipv6 in ip validation and add headers
b5f955d
@patrickszeleczki
Merge pull request #3 from Connatix/add-cnx-adapter
4c7a620 
include ipv6 in ip validation and add headers
@patrickszeleczki
improve test coverage
6b50d55
@patrickszeleczki
Merge branch 'prebid:master' into master
15bdaa2
@patrickszeleczki
Merge branch 'master' into add-cnx-adapter
c29ca38
@patrickszeleczki
Merge pull request #4 from Connatix/add-cnx-adapter
9d79042 
improve test coverage
@patrickszeleczki
Merge branch 'master' into master
a69ba3c
@patrickszeleczki
use v3 package version
ce01457
@patrickszeleczki
Merge pull request #5 from Connatix/add-cnx-adapter
4be32f5 
Increment package version to v3
@patrickszeleczki
add nil check before accessing Device fields
66d781c
@patrickszeleczki
remove validations already handled by PBS core
8d50d87
@patrickszeleczki
small improvements
967e769
@patrickszeleczki
delete tests for removed validations
586d31c
@patrickszeleczki
add more supplemental tests
181c4f9
@github-actions GitHub Actions
Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 4602a90

connatix

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/connatix/connatix.go:23:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/connatix/connatix.go:30:	MakeRequests		100.0%
github.com/prebid/prebid-server/v3/adapters/connatix/connatix.go:65:	MakeBids		95.0%
github.com/prebid/prebid-server/v3/adapters/connatix/connatix.go:105:	validateAndBuildImpExt	100.0%
github.com/prebid/prebid-server/v3/adapters/connatix/connatix.go:114:	splitRequests		93.1%
github.com/prebid/prebid-server/v3/adapters/connatix/connatix.go:170:	buildRequestImp		100.0%
github.com/prebid/prebid-server/v3/adapters/connatix/connatix.go:214:	buildDisplayManagerVer	88.9%
github.com/prebid/prebid-server/v3/adapters/connatix/connatix.go:232:	getBidType		100.0%
total:									(statements)		96.1%

@monicaroxanabota monicaroxanabota changed the title Add viewability fields for connatix adaptor Connatix adapter: Add viewability fields Jan 20, 2025
@github-actions GitHub Actions
Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 82d2961

connatix

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/connatix/connatix.go:23:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/connatix/connatix.go:30:	MakeRequests		100.0%
github.com/prebid/prebid-server/v3/adapters/connatix/connatix.go:65:	MakeBids		95.0%
github.com/prebid/prebid-server/v3/adapters/connatix/connatix.go:105:	validateAndBuildImpExt	100.0%
github.com/prebid/prebid-server/v3/adapters/connatix/connatix.go:114:	splitRequests		93.1%
github.com/prebid/prebid-server/v3/adapters/connatix/connatix.go:170:	buildRequestImp		100.0%
github.com/prebid/prebid-server/v3/adapters/connatix/connatix.go:213:	buildDisplayManagerVer	88.9%
github.com/prebid/prebid-server/v3/adapters/connatix/connatix.go:231:	getBidType		100.0%
total:									(statements)		96.1%

@monicaroxanabota monicaroxanabota changed the title Connatix adapter: Add viewability fields Connatix adapter: Add viewability field Jan 20, 2025
@github-actions GitHub Actions
Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, abaaced

connatix

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/connatix/connatix.go:23:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/connatix/connatix.go:30:	MakeRequests		100.0%
github.com/prebid/prebid-server/v3/adapters/connatix/connatix.go:65:	MakeBids		95.0%
github.com/prebid/prebid-server/v3/adapters/connatix/connatix.go:105:	validateAndBuildImpExt	100.0%
github.com/prebid/prebid-server/v3/adapters/connatix/connatix.go:114:	splitRequests		93.1%
github.com/prebid/prebid-server/v3/adapters/connatix/connatix.go:170:	buildRequestImp		100.0%
github.com/prebid/prebid-server/v3/adapters/connatix/connatix.go:213:	buildDisplayManagerVer	88.9%
github.com/prebid/prebid-server/v3/adapters/connatix/connatix.go:231:	getBidType		100.0%
total:									(statements)		96.1%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karimMourra karimMourra karimMourra approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@monicaroxanabota @karimMourra @patrickszeleczki