New Metrics: Open Telemetry #4065
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SyntaxNode
reviewed
Nov 20, 2024
| @@ -1,10 +1,13 @@ | |||
| module github.com/prebid/prebid-server/v3 | |||
|
|
|||
| go 1.21 | |||
| go 1.22 | |||
There was a problem hiding this comment.
This should be extracted to a separate PR. We release Go upgrades separately to isolate potential issues introduced by the runtime.
| @@ -1,10 +1,12 @@ | |||
| package config | |||
|
|
|||
| import ( | |||
| "log/slog" | |||
There was a problem hiding this comment.
Please continue to use glog for this PR. We'll discuss changing logging libraries in a separate thread.
| } | ||
|
|
||
| // InitMetrics initializes all metrics in the given struct (except those tagged with metric="-"). | ||
| func InitMetrics(meter metric.Meter, m any, prefix string) error { |
There was a problem hiding this comment.
Curious, is this a required step or a pre-optimization similar to what we have for Prometheus?
| return nil, err | ||
| } | ||
| return ret, nil | ||
| } |
There was a problem hiding this comment.
How are OpenTelemetry metrics published?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds an open telemetry
MetricsEngine