-
Notifications
You must be signed in to change notification settings - Fork 744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Blue: Add placementId bidder param #4051
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please open up a docs PR and leave the link on this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see a adapters/blue/params_test.go
file. Please add it to ensure your bidder params rules defined in your static/bidder-params/blue.json
file are working properly. I suggest copying it from another adapter as a starting point.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
Code coverage summaryNote:
blueRefer here for heat map coverage report
|
Code coverage summaryNote:
blueRefer here for heat map coverage report
|
This pull request refers to add a new parameter
placementId
at the bidder-params of Blue bidder.🏷 Type of documentation
📋 Checklist