Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blue: Add placementId bidder param #4051

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

samuelfabel
Copy link
Contributor

@samuelfabel samuelfabel commented Nov 12, 2024

This pull request refers to add a new parameter placementId at the bidder-params of Blue bidder.

🏷 Type of documentation

  • new bid adapter
  • update bid adapter
  • new feature
  • text edit only (wording, typos)
  • bugfix (code examples)
  • new examples

📋 Checklist

@SyntaxNode SyntaxNode changed the title Add a new property called "placementId" to the Blue adapter params sc… Blue: Add a new "placementId" bidder param Nov 13, 2024
@bsardo bsardo changed the title Blue: Add a new "placementId" bidder param Blue: Add placementId bidder param Nov 22, 2024
@bsardo bsardo self-assigned this Nov 22, 2024
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please open up a docs PR and leave the link on this PR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see a adapters/blue/params_test.go file. Please add it to ensure your bidder params rules defined in your static/bidder-params/blue.json file are working properly. I suggest copying it from another adapter as a starting point.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 0d9fd7f

blue

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/blue/blue.go:20:	Builder		100.0%
github.com/prebid/prebid-server/v3/adapters/blue/blue.go:28:	MakeRequests	85.7%
github.com/prebid/prebid-server/v3/adapters/blue/blue.go:49:	MakeBids	100.0%
total:								(statements)	95.8%

Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, d32141c

blue

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/blue/blue.go:20:	Builder		100.0%
github.com/prebid/prebid-server/v3/adapters/blue/blue.go:28:	MakeRequests	85.7%
github.com/prebid/prebid-server/v3/adapters/blue/blue.go:49:	MakeBids	100.0%
total:								(statements)	95.8%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants