Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Catch panic in executeHook #4025

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Catch panic in executeHook #4025

wants to merge 3 commits into from

Conversation

linux019
Copy link
Contributor

@linux019 linux019 commented Oct 30, 2024 •
edited
Loading

@linux019 linux019 changed the title #3737 catch panic in executeHook Catch panic in executeHook Oct 30, 2024
@SyntaxNode
Copy link
Contributor

Good addition. Please add extra context including the module and hook which caused a panic, similar to the adapter panic error information. Might also be a good idea to add a module panic metric to mirror the adapter panic metric.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@linux019 @SyntaxNode