Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exitpoint Stage #3564

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Exitpoint Stage #3564

wants to merge 6 commits into from

Conversation

AntoxaAntoxic
Copy link
Collaborator

🔧 Type of changes

  • new bid adapter
  • update bid adapter
  • new feature
  • new analytics adapter
  • new module
  • bugfix
  • documentation
  • configuration
  • tech debt (test coverage, refactorings, etc.)

✨ What's the context?

prebid/prebid-server#4044

🧠 Rationale behind the change

Why did you choose to make these changes? Were there any trade-offs you had to consider?

🔎 New Bid Adapter Checklist

  • verify email contact works
  • NO fully dynamic hosts
  • geographic host parameters are NOT required
  • NO direct use of HTTP is prohibited - implement an existing Bidder interface that will do all the job
  • if the ORTB is just forwarded to the endpoint, use the generic adapter - define the new adapter as the alias of the generic adapter
  • cover an adapter configuration with an integration test

🧪 Test plan

How do you know the changes are safe to ship to production?

🏎 Quality check

  • Are your changes following our code style guidelines?
  • Are there any breaking changes in your code?
  • Does your test coverage exceed 90%?
  • Are there any erroneous console logs, debuggers or leftover code in your changes?

@AntoxaAntoxic AntoxaAntoxic self-assigned this Nov 21, 2024
@Net-burst
Copy link
Collaborator

You missed StageMetrics metric.

private final JacksonMapper mapper;
private final double logSamplingRate;

public AmpHandler(AmpRequestFactory ampRequestFactory,
ExchangeService exchangeService,
AnalyticsReporterDelegator analyticsDelegator,
Metrics metrics,
Metrics metrics, HooksMetricsService hooksMetricsService,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style

Clock clock,
BidderCatalog bidderCatalog,
Set<String> biddersSupportingCustomTargeting,
AmpResponsePostProcessor ampResponsePostProcessor,
HttpInteractionLogger httpInteractionLogger,
PrebidVersionProvider prebidVersionProvider,
PrebidVersionProvider prebidVersionProvider, HookStageExecutor hookStageExecutor,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants