Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ownerdocument rebased #4501

Open
wants to merge 20 commits into
base: main
Choose a base branch
from

Conversation

alshdavid
Copy link

No description provided.

@JoviDeCroock
Copy link
Member

Looks like the tests are currently failing when passing in document as a render-target. This is a valid use-case to render a full HTML tree and that indeed has null for the ownerDocument so we'd have to take a null'ish ownerDocument into account and default to document I reckon.

@hzy
Copy link

hzy commented Sep 27, 2024

It looks like some of the tests regarding types are not passing, would the following changes help?

diff --git a/test/ts/preact.tsx b/test/ts/preact.tsx
index 3713f9d8..e6d81eb3 100644
--- a/test/ts/preact.tsx
+++ b/test/ts/preact.tsx
@@ -102,7 +102,8 @@ function createRootFragment(parent: Element, replaceNode: Element | Element[]) {
                appendChild: (c: Node) => insert(c, null),
                removeChild: function (c: Node) {
                        return parent.removeChild(c);
-               }
+               },
+               ownerDocument: parent.ownerDocument,
        });
 }

@JoviDeCroock
Copy link
Member

CC @marvinhagemeister how should we best handle the undefined case you think, might be relevant for fresh?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants