Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes
Running into a lot of issues backporting #4088 because when we look up the dom in the
parentInternal
we basically run into the fact that we haven't reordered the parent children yet. I can make it behave a lot better by doinglet nextSibling = getDomSibling({ _children: newChildren }, skewedIndex + 1);
inchildren.js
however that breaks a lot of other tests. The aforementioned issue might need a backport of the children algo split-up sooner where we first calculate the new _children array and then perform operations.TODO:
ComponentChild
asReactNode
in compat's types #4077gotpointercapture
andlostpointercapture
events #4096