Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: avoid registering non-function event-handlers on custom-elements #4121

Closed
wants to merge 1 commit into from
Closed

fix: avoid registering non-function event-handlers on custom-elements #4121

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions test/browser/render.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,24 @@
expect(scratch.firstChild).to.have.property('nodeName', 'X-BAR');
});

it('should not register non-function event handlers', () => {
const proto = Element.prototype;
proto.addEventListener.resetHistory();
render(
<x-bar
only-overflow={true}

Check failure on line 138 in test/browser/render.test.js

View workflow job for this annotation

GitHub Actions / Build & Test 

Value must be omitted for boolean attributes
onChange={() => {
console.log('Change');

Check warning on line 140 in test/browser/render.test.js

View workflow job for this annotation

GitHub Actions / Build & Test 

Unexpected console statement
}}
/>,
scratch
);

expect(proto.addEventListener).to.have.been.calledOnce;
expect(scratch.childNodes).to.have.length(1);
expect(scratch.firstChild).to.have.property('nodeName', 'X-BAR');
});

it('should support the form attribute', () => {
render(
<div>
Expand Down
Loading