Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt to React api: add context argument to compat/Children map api #3855

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ParSal123
Copy link

React's children api map function supports a "context" argument that we don't.
Fixes #2644.

Based mostly on #2645.

There was a problem though: When I ran npm run test:karma, it didn't test Children.test.js. Even the pipeline on the forked project didn't run Children.test.js. I couldn't figure it out. Don't know if this is an issue or just misconfiguration.

React's children api map function supports a "context" argument that we
don't.
See preactjs#2644.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Differences in Preact.Children API and React.Children API
2 participants