Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: add note about pre-push hooks not being triggered on ref deletions #893

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Docs: add note about pre-push hooks not being triggered on ref deletions #893

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions sections/advanced.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,6 +182,8 @@ Note that you need to be using at least git 2.24 for this hook.

`pre-push` is triggered on `git push`.

note: `pre-push` hooks are not triggered for ref deletions.

Comment on lines +185 to +186
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's a bit more nuance to this than just that -- the variables below imply this is already the case since there must be a from-ref and a to-ref

Copy link
Author

@whophil whophil Nov 3, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on the environment variables, I was expecting PRE_COMMIT_TO_REF to be 0000000000000000000000000000000000000000 here, in the case of a ref deletion.

Would you propose an alternate wording, or not documenting this at all?

environment variables:
- `PRE_COMMIT_FROM_REF`: the revision that is being pushed to.
- `PRE_COMMIT_TO_REF`: the local revision that is being pushed to the remote.
Expand Down