SDK: Fix FFieldClass::s_name_offset on old UE builds

praydog · Oct 22, 2023 · 593463f · 593463f
1 parent b14e344
commit 593463f
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 2 deletions.
diff --git a/shared/sdk/FName.cpp b/shared/sdk/FName.cpp
@@ -458,8 +458,7 @@ std::wstring FName::to_string() const {
     fn(this, &buffer);
 
     if (buffer.data != nullptr) {
-        std::wstring result = buffer.data;
-        return result;
+        return buffer.data;
     }
 
     return std::wstring{};

diff --git a/shared/sdk/TArray.hpp b/shared/sdk/TArray.hpp
@@ -17,6 +17,8 @@ struct TArray {
             return;
         }
 
+        // TODO: call destructors?
+
         if (auto m = FMalloc::get(); m != nullptr) {
             m->free(data);
         }

diff --git a/shared/sdk/UClass.cpp b/shared/sdk/UClass.cpp
@@ -99,6 +99,7 @@ void UStruct::resolve_field_offsets(uint32_t child_search_start) {
 
                     if (class_offset) {
                         FField::s_class_offset = *class_offset - (uintptr_t)potential_field;
+                        FFieldClass::s_name_offset = UObjectBase::s_fname_offset;
                         found_ufield_class_offset = true;
                         SPDLOG_INFO("[UStruct] Found FField/UField Class at offset 0x{:X}", FField::s_class_offset);
                     }
@@ -110,6 +111,7 @@ void UStruct::resolve_field_offsets(uint32_t child_search_start) {
 
                     if (class_offset) {
                         FField::s_class_offset = *class_offset - (uintptr_t)potential_field;
+                        FFieldClass::s_name_offset = UObjectBase::s_fname_offset;
                         found_ufield_class_offset = true;
                         SPDLOG_INFO("[UStruct] Found FField/UField Class at offset 0x{:X}", FField::s_class_offset);
                     }
-Original file line number
+Diff line change
@@ Expand Up / @@ -17,6 +17,8 @@ struct TArray { @@
                 return;
             }
+            // TODO: call destructors?
             if (auto m = FMalloc::get(); m != nullptr) {
                 m->free(data);
             }
@@ Expand Down @@