Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Footer #46

Closed
wants to merge 1 commit into from
Closed

Adding Footer #46

wants to merge 1 commit into from
+50 −35

Conversation

sristy17
Copy link

@sristy17 sristy17 commented Jul 6, 2024

Description

Adding Footer

Fixes #35

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@vercel Vercel
Copy link

vercel bot commented Jul 6, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
automarket-s42l ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 6, 2024 5:45am

github-actions[bot]
github-actions bot reviewed Jul 6, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to Our repository.🎊 Thank you so much for taking the time to point this out.

@prathamjagga
Copy link
Owner

@sristy17 add the

tag in src/app/layout.tsx file at the end of tag and remove it from other files. This will keep the footer on every page since it will then be defined in the layout.

@prathamjagga
Copy link
Owner

I have tested it on my machine and it is working

@sristy17
Copy link
Author

sristy17 commented Jul 7, 2024

I have tested it on my machine and it is working

Thanks will try for sure!

@sristy17
Copy link
Author

sristy17 commented Jul 8, 2024

@sristy17 add the

tag in src/app/layout.tsx file at the end of tag and remove it from other files. This will keep the footer on every page since it will then be defined in the layout.

M still not getting! How to add this just a hint!

@prathamjagga
Copy link
Owner

Just add footer.tsx in _components and add that footer in the layout file. Also, the footer will be visible after scrolling to the bottom only.
src/app/layout.tsx should look like this:

import "~/styles/globals.css";

import { Inter } from "next/font/google";

// import { TRPCReactProvider } from "~/trpc/react";

const inter = Inter({
  subsets: ["latin"],
  variable: "--font-sans",
});

export const metadata = {
  title: "AutoMarket",
  description: "The Web Platform for Micro-automations",
  icons: [{ rel: "icon", url: "/favicon.ico" }],
};

import Footer from "./_components/footer";

export default function RootLayout({
  children,
}: {
  children: React.ReactNode;
}) {
  return (
    <html lang="en">
      <body className={`font-sans ${inter.variable}`}>
        <>{children}</>
        <Footer/>
      </body>
    </html>
  );
}

@sristy17
Copy link
Author

Just add footer.tsx in _components and add that footer in the layout file. Also, the footer will be visible after scrolling to the bottom only. src/app/layout.tsx should look like this:

import "~/styles/globals.css";

import { Inter } from "next/font/google";

// import { TRPCReactProvider } from "~/trpc/react";

const inter = Inter({
  subsets: ["latin"],
  variable: "--font-sans",
});

export const metadata = {
  title: "AutoMarket",
  description: "The Web Platform for Micro-automations",
  icons: [{ rel: "icon", url: "/favicon.ico" }],
};

import Footer from "./_components/footer";

export default function RootLayout({
  children,
}: {
  children: React.ReactNode;
}) {
  return (
    <html lang="en">
      <body className={`font-sans ${inter.variable}`}>
        <>{children}</>
        <Footer/>
      </body>
    </html>
  );
}

Hey i need a help, if you dont mind can we connect on discord?

@prathamjagga
Copy link
Owner

sure, just ping on this username: pratham

Just add footer.tsx in _components and add that footer in the layout file. Also, the footer will be visible after scrolling to the bottom only. src/app/layout.tsx should look like this:

import "~/styles/globals.css";

import { Inter } from "next/font/google";

// import { TRPCReactProvider } from "~/trpc/react";

const inter = Inter({
  subsets: ["latin"],
  variable: "--font-sans",
});

export const metadata = {
  title: "AutoMarket",
  description: "The Web Platform for Micro-automations",
  icons: [{ rel: "icon", url: "/favicon.ico" }],
};

import Footer from "./_components/footer";

export default function RootLayout({
  children,
}: {
  children: React.ReactNode;
}) {
  return (
    <html lang="en">
      <body className={`font-sans ${inter.variable}`}>
        <>{children}</>
        <Footer/>
      </body>
    </html>
  );
}

Hey i need a help, if you dont mind can we connect on discord?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees
No one assigned
Labels
stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Footer to the website.
2 participants
@sristy17 @prathamjagga