Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate fake AMQP channel from real AMQP client #1002

Merged
merged 3 commits into from
Nov 3, 2015

Conversation

jerith
Copy link
Member

@jerith jerith commented Nov 3, 2015

We have a few tests that look for fake AQMP things on the channel objects belonging to clients. As part of the work in #1000, AMQP clients will get real channel objects instead fake ones and will have to look at channel._fake_channel to get at the fake stuff.

To make that transition easier, it seems sensible to wrap the current fake channel with a more realistic one and expose the underlying fake on channel._fake_channel.

Review on Reviewable

@jerith jerith self-assigned this Nov 3, 2015
@smn
Copy link
Member

smn commented Nov 3, 2015

👍


Reviewed 8 of 8 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from the review on Reviewable.io

@JayH5
Copy link
Contributor

JayH5 commented Nov 3, 2015

👍


Comments from the review on Reviewable.io

@JayH5
Copy link
Contributor

JayH5 commented Nov 3, 2015

Reviewed 8 of 8 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks pending.


Comments from the review on Reviewable.io

@jerith jerith merged commit 0421fea into develop Nov 3, 2015
@jerith jerith deleted the feature/issue-1002-separate-fake-channel branch November 3, 2015 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants