Merge pull request #161 from praekeltfoundation/fix-submit-transactio…

…n-body Fix submit transaction body
praekeltfoundation · Sep 12, 2023 · 78f49d7 · 78f49d7
2 parents 67fe154 + e279f49
commit 78f49d7
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/rp_dtone/dtone_client.py b/rp_dtone/dtone_client.py
@@ -37,7 +37,7 @@ def get_fixed_value_product(self, operator_id, value):
 
  def submit_transaction(self, transaction_uuid, msisdn, product_id):
  body = {
- "external_id": transaction_uuid,
+ "external_id": str(transaction_uuid),
  "product_id": product_id,
  "auto_confirm": True,
  "credit_party_identifier": {"mobile_number": msisdn},

diff --git a/rp_dtone/tests/test_dtone_client.py b/rp_dtone/tests/test_dtone_client.py
@@ -1,4 +1,5 @@
 import json
+import uuid
 
 import responses
 from django.test import TestCase
@@ -60,7 +61,8 @@ def test_submit_transaction(self):
  status=200,
  )
 
- self.client.submit_transaction("transaction-uuid", "+27123", 123)
+ transaction_uuid = uuid.uuid4()
+ self.client.submit_transaction(transaction_uuid, "+27123", 123)
 
  request = responses.calls[0].request
  self.assertEqual(
@@ -71,7 +73,7 @@ def test_submit_transaction(self):
  self.assertEqual(
  json.loads(request.body),
  {
- "external_id": "transaction-uuid",
+ "external_id": str(transaction_uuid),
  "product_id": 123,
  "auto_confirm": True,
  "credit_party_identifier": {"mobile_number": "+27123"},