Skip to content

Commit

Permalink
chore: upgrade deps and remove react 17 warnings (#431)
Browse files Browse the repository at this point in the history
  • Loading branch information
pradel authored Oct 28, 2020
1 parent f4d9f37 commit 8bbfadf
Show file tree
Hide file tree
Showing 13 changed files with 2,515 additions and 1,247 deletions.
7 changes: 0 additions & 7 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -48,13 +48,6 @@ jobs:

- name: Build
run: yarn build
env:
CI: true

- name: Test size
run: yarn size
env:
CI: true

- name: Build docs
run: yarn docz:build
Expand Down
14 changes: 14 additions & 0 deletions .github/workflows/size.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
name: size

on: [pull_request]

jobs:
size:
runs-on: ubuntu-latest
env:
CI_JOB_NUMBER: 1
steps:
- uses: actions/checkout@v1
- uses: andresz1/size-limit-action@v1
with:
github_token: ${{ secrets.GITHUB_TOKEN }}
20 changes: 0 additions & 20 deletions .travis.yml

This file was deleted.

2 changes: 1 addition & 1 deletion .yarn/plugins/@yarnpkg/plugin-interactive-tools.cjs

Large diffs are not rendered by default.

55 changes: 0 additions & 55 deletions .yarn/releases/yarn-2.2.1.cjs

This file was deleted.

55 changes: 55 additions & 0 deletions .yarn/releases/yarn-2.3.3.cjs

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion .yarnrc.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,4 @@ plugins:
- path: .yarn/plugins/@yarnpkg/plugin-interactive-tools.cjs
spec: "@yarnpkg/plugin-interactive-tools"

yarnPath: .yarn/releases/yarn-2.2.1.cjs
yarnPath: .yarn/releases/yarn-2.3.3.cjs
8 changes: 4 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
[![codecov](https://img.shields.io/codecov/c/github/pradel/react-responsive-modal/master.svg)](https://codecov.io/gh/pradel/react-responsive-modal)
[![dependencies Status](https://david-dm.org/pradel/react-responsive-modal/status.svg)](https://david-dm.org/pradel/react-responsive-modal)

A simple responsive and accessible react modal compatible with React 16 and ready for React 17.
A simple responsive and accessible react modal.

- Focus trap inside the modal.
- Centered modals.
Expand Down Expand Up @@ -44,10 +44,10 @@ import ReactDOM from 'react-dom';
import 'react-responsive-modal/styles.css';
import { Modal } from 'react-responsive-modal';

const App = () => {
const App = () => {
const [open, setOpen] = useState(false);

const onOpenModal = () => setOpen(true);
const onOpenModal = () => setOpen(true);
const onCloseModal = () => setOpen(false);

return (
Expand All @@ -58,7 +58,7 @@ const App = () => {
</Modal>
</div>
);
}
};

ReactDOM.render(<App />, document.getElementById('app'));
```
Expand Down
2 changes: 1 addition & 1 deletion docs/index.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import { Modal } from '../src/index.tsx';

# react-responsive-modal

A simple responsive and accessible react modal compatible with React 16 and ready for React 17.
A simple responsive and accessible react modal.

- Focus trap inside the modal.
- Centered modals.
Expand Down
2 changes: 1 addition & 1 deletion netlify.toml
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,5 @@

[build.environment]
NODE_VERSION = "12"
YARN_VERSION = "1.22.4"
YARN_VERSION = "1.22.5"
YARN_FLAGS = "--immutable"
38 changes: 21 additions & 17 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "react-responsive-modal",
"version": "5.1.1",
"description": "A simple responsive and accessible react modal compatible with React 16 and ready for React 17",
"description": "A simple responsive and accessible react modal",
"license": "MIT",
"main": "dist/index.js",
"module": "dist/react-responsive-modal.esm.js",
Expand Down Expand Up @@ -51,7 +51,11 @@
"funding": "https://github.com/sponsors/pradel",
"size-limit": [
{
"path": "dist/index.js",
"path": "dist/react-responsive-modal.cjs.production.min.js",
"limit": "3.1 KB"
},
{
"path": "dist/react-responsive-modal.esm.js",
"limit": "3.1 KB"
}
],
Expand All @@ -60,30 +64,30 @@
"no-scroll": "^2.1.1"
},
"peerDependencies": {
"react": "^16.8.0",
"react-dom": "^16.8.0"
"react": "^16.8.0 || ^17",
"react-dom": "^16.8.0 || ^17"
},
"devDependencies": {
"@size-limit/preset-small-lib": "4.5.7",
"@size-limit/preset-small-lib": "4.7.0",
"@testing-library/jest-dom": "5.11.4",
"@testing-library/react": "10.4.9",
"@types/classnames": "2.2.10",
"@types/no-scroll": "2.1.0",
"@types/node": "14.0.27",
"@types/react": "16.9.39",
"@types/react-dom": "16.9.8",
"@types/node": "14.14.5",
"@types/react": "16.9.54",
"@types/react-dom": "16.9.9",
"@types/react-transition-group": "4.4.0",
"codecov": "3.7.2",
"codecov": "3.8.0",
"docz": "2.3.1",
"gatsby": "2.23.11",
"gatsby-theme-docz": "2.3.1",
"husky": "4.2.5",
"prettier": "2.1.1",
"react": "16.13.1",
"react-dom": "16.13.1",
"size-limit": "4.5.7",
"tsdx": "0.13.3",
"tslib": "2.0.1",
"typescript": "4.0.2"
"husky": "4.3.0",
"prettier": "2.1.2",
"react": "16.14.0",
"react-dom": "16.14.0",
"size-limit": "4.7.0",
"tsdx": "0.14.1",
"tslib": "2.0.3",
"typescript": "4.0.5"
}
}
19 changes: 6 additions & 13 deletions tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,22 +8,15 @@
"sourceMap": true,
"rootDir": "./src",
"strict": true,
"noImplicitAny": true,
"strictNullChecks": true,
"strictFunctionTypes": true,
"strictPropertyInitialization": true,
"noImplicitThis": true,
"alwaysStrict": true,
"noUnusedLocals": true,
"noUnusedParameters": true,
"noImplicitReturns": true,
"noFallthroughCasesInSwitch": true,
"noUnusedLocals": true,
"noUnusedParameters": true,
"moduleResolution": "node",
"baseUrl": "./",
"paths": {
"*": ["src/*", "node_modules/*"]
},
"jsx": "react",
"esModuleInterop": true
"esModuleInterop": true,
"skipLibCheck": true,
"forceConsistentCasingInFileNames": true,
"noEmit": true
}
}
Loading

0 comments on commit 8bbfadf

Please sign in to comment.