Day3 homework #9
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for being fast. First somewhat minor comment - you usually don't want to put generated output files into version control - like
|
| # Do the interpolation; | ||
| time_offset = slice_times/slice_times.shape * TR |
There was a problem hiding this comment.
Actually, I was intending that the input array is the thing you are calling time_offset here. I didn't specifically say this - sorry for that - but the clue is in the docstring above "The time in seconds ... relative to the start of the TR ...".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solutions to slice_timing.ipynb and slice_time_image.py files, as well as the output interpolated nifti image from slice_time_image.py