Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Nucleo l4r5 #55

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

cothan
Copy link

@cothan cothan commented Oct 3, 2024

Fixes #54

  • Does this PR change the input/output behaviour of a cryptographic algorithm (i.e., does it change known answer test values)? (If so, a version bump will be required from x.y.z to x.(y+1).0.)

@cothan cothan requested a review from a team as a code owner October 3, 2024 23:02
@cothan cothan force-pushed the add_default_pqm4_board branch 2 times, most recently from 7279b2f to 3434731 Compare October 4, 2024 02:52
Copy link
Contributor

@mkannwischer mkannwischer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this @cothan.
Works fine and looking mostly good.
Can you make the following changes/answer my questions please?

libopencm3.nix Outdated Show resolved Hide resolved
libopencm3.nix Outdated Show resolved Hide resolved
libopencm3.nix Outdated Show resolved Hide resolved
Signed-off-by: Duc Tri Nguyen <[email protected]>

format

Signed-off-by: Duc Tri Nguyen <[email protected]>

revert the changes to libopencm3
Copy link
Contributor

@mkannwischer mkannwischer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I am running
tests stack nucleo-l4r5zi -v

I'm getting the following

DEBUG > Waiting for start marker
DEBUG > Reading input
DEBUG > keypair stack usage:
4294967268
encaps stack usage:
4294967268
decaps stack usage:
4294967268
OK KEYS

That looks wrong. Do you also see that? Can you look into that, please? Stack measurements are always a bit fragile, unfortunately.

@cothan
Copy link
Author

cothan commented Oct 24, 2024

@mkannwischer , I confirm I see the same problem. I'm not sure why, all the code I copy from pqm4 repo. I'll look into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support PQM4 Default board: nucleo-l4r5zi
2 participants