Skip to content

Redesign editor setup screen with new "form" controls #21902

Redesign editor setup screen with new "form" controls

Redesign editor setup screen with new "form" controls #21902

GitHub Actions / Test Results (Linux, SingleThread) failed Oct 3, 2024 in 0s

10539 passed, 1 failed and 74 skipped

Tests failed

❌ TestResults-Linux-SingleThread.trx

10614 tests were completed in 1905s with 10539 passed, 1 failed and 74 skipped.

Test suite Passed Failed Skipped Time
osu.Game.Tests.Editing.TestSceneHitObjectComposerDistanceSnapping 31✅ 1❌ 4s

❌ osu.Game.Tests.Editing.TestSceneHitObjectComposerDistanceSnapping

✅ GetSnappedDistanceFromDistance
✅ GetSnappedDistanceFromDistance
✅ TestBeatDivisor(1)
✅ TestBeatDivisor(1)
✅ TestBeatDivisor(2)
✅ TestBeatDivisor(2)
✅ TestConstructor
✅ TestConstructor
✅ TestConversionsWithSliderVelocity
✅ TestConversionsWithSliderVelocity
✅ TestConvertDistanceToDuration
✅ TestConvertDistanceToDuration
✅ TestConvertDurationToDistance
✅ TestConvertDurationToDistance
✅ TestGetSnappedDurationFromDistance
✅ TestGetSnappedDurationFromDistance
✅ TestSliderMultiplier(1)
✅ TestSliderMultiplier(1)
✅ TestSliderMultiplier(2)
✅ TestSliderMultiplier(2)
✅ TestSpeedMultiplierDoesChangeDistanceSnap(1)
✅ TestSpeedMultiplierDoesChangeDistanceSnap(1)
✅ TestSpeedMultiplierDoesChangeDistanceSnap(2)
✅ TestSpeedMultiplierDoesChangeDistanceSnap(2)
✅ TestSpeedMultiplierDoesNotChangeDistanceSnap(1)
✅ TestSpeedMultiplierDoesNotChangeDistanceSnap(1)
✅ TestSpeedMultiplierDoesNotChangeDistanceSnap(2)
✅ TestSpeedMultiplierDoesNotChangeDistanceSnap(2)
❌ TestUnsnappedObject
	System.InvalidOperationException : Failed to compare two elements in the array.
	  ----> System.NullReferenceException : Object reference not set to an instance of an object.
✅ TestUnsnappedObject
✅ TestUseCurrentSnap
✅ TestUseCurrentSnap

Annotations

Check failure on line 61 in osu.Game.Rulesets.Osu/Objects/Drawables/Connections/FollowPointRenderer.cs

See this annotation in the file changed.

@github-actions github-actions / Test Results (Linux, SingleThread)

osu.Game.Tests.Editing.TestSceneHitObjectComposerDistanceSnapping ► TestUnsnappedObject

Failed test found in:
  TestResults-Linux-SingleThread.trx
Error:
  System.InvalidOperationException : Failed to compare two elements in the array.
    ----> System.NullReferenceException : Object reference not set to an instance of an object.
Raw output
System.InvalidOperationException : Failed to compare two elements in the array.
  ----> System.NullReferenceException : Object reference not set to an instance of an object.
   at System.Collections.Generic.ArraySortHelper`1.BinarySearch(T[] array, Int32 index, Int32 length, T value, IComparer`1 comparer)
   at osu.Framework.Extensions.ExtensionMethods.AddInPlace[T](List`1 list, T item, IComparer`1 comparer)
   at osu.Game.Rulesets.Osu.Objects.Drawables.Connections.FollowPointRenderer.addEntry(OsuHitObject hitObject) in /home/runner/work/osu/osu/osu.Game.Rulesets.Osu/Objects/Drawables/Connections/FollowPointRenderer.cs:line 61
   at osu.Game.Rulesets.Osu.Objects.Drawables.Connections.FollowPointRenderer.AddFollowPoints(OsuHitObject hitObject) in /home/runner/work/osu/osu/osu.Game.Rulesets.Osu/Objects/Drawables/Connections/FollowPointRenderer.cs:line 42
   at osu.Game.Rulesets.Osu.UI.OsuPlayfield.OnHitObjectAdded(HitObject hitObject) in /home/runner/work/osu/osu/osu.Game.Rulesets.Osu/UI/OsuPlayfield.cs:line 178
   at osu.Game.Rulesets.UI.Playfield.onEntryAdded(HitObjectLifetimeEntry entry, HitObject parentHitObject) in /home/runner/work/osu/osu/osu.Game/Rulesets/UI/Playfield.cs:line 342
   at osu.Game.Rulesets.Objects.Pooling.HitObjectEntryManager.Add(HitObjectLifetimeEntry entry, HitObject parent) in /home/runner/work/osu/osu/osu.Game/Rulesets/Objects/Pooling/HitObjectEntryManager.cs:line 62
   at osu.Game.Rulesets.UI.Playfield.Add(HitObject hitObject) in /home/runner/work/osu/osu/osu.Game/Rulesets/UI/Playfield.cs:line 305
   at osu.Game.Rulesets.UI.DrawableRuleset`1.AddHitObject(TObject hitObject) in /home/runner/work/osu/osu/osu.Game/Rulesets/UI/DrawableRuleset.cs:line 274
   at osu.Game.Rulesets.Edit.DrawableEditorRulesetWrapper`1.addHitObject(HitObject hitObject) in /home/runner/work/osu/osu/osu.Game/Rulesets/Edit/DrawableEditorRulesetWrapper.cs:line 76
   at osu.Game.Screens.Edit.EditorBeatmap.UpdateState() in /home/runner/work/osu/osu/osu.Game/Screens/Edit/EditorBeatmap.cs:line 389
   at osu.Game.Screens.Edit.TransactionalCommitComponent.EndChange() in /home/runner/work/osu/osu/osu.Game/Screens/Edit/TransactionalCommitComponent.cs:line 53
   at osu.Game.Screens.Edit.EditorBeatmap.Insert(Int32 index, HitObject hitObject) in /home/runner/work/osu/osu/osu.Game/Screens/Edit/EditorBeatmap.cs:line 271
   at osu.Game.Screens.Edit.EditorBeatmap.Add(HitObject hitObject) in /home/runner/work/osu/osu/osu.Game/Screens/Edit/EditorBeatmap.cs:line 252
   at osu.Game.Tests.Editing.TestSceneHitObjectComposerDistanceSnapping.<>c__DisplayClass16_0.<TestUnsnappedObject>b__0() in /home/runner/work/osu/osu/osu.Game.Tests/Editing/TestSceneHitObjectComposerDistanceSnapping.cs:line 249
   at osu.Framework.Testing.Drawables.Steps.SingleStepButton.<.ctor>b__1_0()
   at osu.Framework.Testing.Drawables.Steps.StepButton.PerformStep(Boolean userTriggered)
   at osu.Framework.Testing.TestScene.runNextStep(Action onCompletion, Action`1 onError, Func`2 stopCondition)
--- End of stack trace from previous location ---
   at osu.Framework.Testing.TestSceneTestRunner.TestRunner.RunTestBlocking(TestScene test)
   at osu.Game.Tests.Visual.OsuTestScene.OsuTestSceneTestRunner.RunTestBlocking(TestScene test) in /home/runner/work/osu/osu/osu.Game/Tests/Visual/OsuTestScene.cs:line 541
   at osu.Framework.Testing.TestScene.UseTestSceneRunnerAttribute.AfterTest(ITest test)
   at NUnit.Framework.Internal.Commands.TestActionCommand.<>c__DisplayClass0_0.<.ctor>b__1(TestExecutionContext context)
   at NUnit.Framework.Internal.Commands.BeforeAndAfterTestCommand.<>c__DisplayClass1_0.<Execute>b__1()
   at NUnit.Framework.Internal.Commands.DelegatingTestCommand.RunTestMethodInThreadAbortSafeZone(TestExecutionContext context, Action action)
--NullReferenceException
   at osu.Game.Rulesets.Osu.Objects.Drawables.Connections.FollowPointRenderer.<>c.<addEntry>b__9_0(FollowPointLifetimeEntry e1, FollowPointLifetimeEntry e2) in /home/runner/work/osu/osu/osu.Game.Rulesets.Osu/Objects/Drawables/Connections/FollowPointRenderer.cs:line 63
   at System.Collections.Generic.ArraySortHelper`1.BinarySearch(T[] array, Int32 index, Int32 length, T value, IComparer`1 comparer)