Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add localisation support for menu tip #30865

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

ItsShamed
Copy link
Contributor

Noticed while watching recent activity on the #github-feed channel on Discord, and thought why this wasn’t a thing already.
This will make the process of adding new tips a bit more tedious though…

osu.Game/Screens/Menu/MenuTip.cs Show resolved Hide resolved
frenzibyte
frenzibyte previously approved these changes Nov 26, 2024
public static LocalisableString ToggleToolbarShortcut => new TranslatableString(getKey(@"toggle_toolbar_shortcut"), @"Press Ctrl-T anywhere in the game to toggle the toolbar!");

/// <summary>
/// "Press Ctrl-O anywhere in the game to access options!"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was renamed in lazer.

Suggested change
/// "Press Ctrl-O anywhere in the game to access options!"
/// "Press Ctrl-O anywhere in the game to access settings!"

public static LocalisableString ModPresets => new TranslatableString(getKey(@"mod_presets"), @"You can create mod presets to make toggling your favorite mod combinations easier!");

/// <summary>
/// "Many mods have customisation settings that drastically change how they function. Click the Mod Customisation button in mod select to view settings!"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/// "Many mods have customisation settings that drastically change how they function. Click the Mod Customisation button in mod select to view settings!"
/// "Many mods have customisation settings that drastically change how they function. Click the Customise button in mod select to view settings!"

public static LocalisableString ConfigurableHotkeys => new TranslatableString(getKey(@"configurable_hotkeys"), @"Most of the hotkeys in the game are configurable and can be changed to anything you want. Check the bindings panel under input settings!");

/// <summary>
/// "Your gameplay HUD can be customized by using the skin layout editor. Open it at any time via Ctrl-Shift-S!"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/// "Your gameplay HUD can be customized by using the skin layout editor. Open it at any time via Ctrl-Shift-S!"
/// "Your gameplay HUD can be customised by using the skin layout editor. Open it at any time via Ctrl-Shift-S!"

@frenzibyte
Copy link
Member

I wouldn't throw a "changes requested" for what are more of corrections based on recent game updates (i.e. irrelevant from this PR) but sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants