Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix slider MinimumJumpDistance being calculated too low to be possible #30036

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+17 −0

Only replace `MinimumJumpDistance` when `LazyJumpDistance` is bigger …

d55c5ef
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Open

Fix slider MinimumJumpDistance being calculated too low to be possible #30036

Only replace `MinimumJumpDistance` when `LazyJumpDistance` is bigger …
d55c5ef
Select commit
Loading
Failed to load commit list.
GitHub Actions / Test Results (Windows, SingleThread) failed Oct 3, 2024 in 0s

10534 passed, 6 failed and 74 skipped

Tests failed

❌ TestResults-Windows-SingleThread.trx

10614 tests were completed in 2782s with 10534 passed, 6 failed and 74 skipped.

Test suite Passed Failed Skipped Time
osu.Game.Rulesets.Osu.Tests.OsuDifficultyCalculatorTest 4✅ 6❌ 289ms

❌ osu.Game.Rulesets.Osu.Tests.OsuDifficultyCalculatorTest

✅ Test(0.14102693012101306d,2,"nan-slider")
✅ Test(0.4250648023083879d,4,"very-fast-slider")
❌ Test(1.4386882251130073d,54,"zero-length-sliders")
	  Expected: 1.4386882251130073d +/- 1.0000000000000001E-05d
	  But was:  1.427174756778619d
	  Off by:   0.011513468334388266d
	
❌ Test(6.710442985146793d,239,"diffcalc-test")
	  Expected: 6.710442985146793d +/- 1.0000000000000001E-05d
	  But was:  6.7100197470443836d
	  Off by:   0.00042323810240940674d
	
✅ TestClassicMod(0.4250648023083879d,4,"very-fast-slider")
❌ TestClassicMod(1.4386882251130073d,54,"zero-length-sliders")
	  Expected: 1.4386882251130073d +/- 1.0000000000000001E-05d
	  But was:  1.427174756778619d
	  Off by:   0.011513468334388266d
	
❌ TestClassicMod(6.710442985146793d,239,"diffcalc-test")
	  Expected: 6.710442985146793d +/- 1.0000000000000001E-05d
	  But was:  6.7100197470443836d
	  Off by:   0.00042323810240940674d
	
✅ TestClockRateAdjusted(0.5507108280047351d,4,"very-fast-slider")
❌ TestClockRateAdjusted(1.743180218215227d,54,"zero-length-sliders")
	  Expected: 1.743180218215227d +/- 1.0000000000000001E-05d
	  But was:  1.7306397334049743d
	  Off by:   0.012540484810252606d
	
❌ TestClockRateAdjusted(8.974295270307167d,239,"diffcalc-test")
	  Expected: 8.9742952703071666d +/- 1.0000000000000001E-05d
	  But was:  8.9727729983409734d
	  Off by:   0.001522271966193145d

Annotations

Check failure on line 31 in osu.Game/Tests/Beatmaps/DifficultyCalculatorTest.cs

See this annotation in the file changed.

@github-actions github-actions / Test Results (Windows, SingleThread)

osu.Game.Rulesets.Osu.Tests.OsuDifficultyCalculatorTest ► Test(1.4386882251130073d,54,"zero-length-sliders") 

Failed test found in:
  TestResults-Windows-SingleThread.trx
Error:
    Expected: 1.4386882251130073d +/- 1.0000000000000001E-05d
    But was:  1.427174756778619d
    Off by:   0.011513468334388266d
Raw output 
  Expected: 1.4386882251130073d +/- 1.0000000000000001E-05d
  But was:  1.427174756778619d
  Off by:   0.011513468334388266d

   at osu.Game.Tests.Beatmaps.DifficultyCalculatorTest.Test(Double expectedStarRating, Int32 expectedMaxCombo, String name, Mod[] mods) in D:\a\osu\osu\osu.Game\Tests\Beatmaps\DifficultyCalculatorTest.cs:line 31
   at osu.Game.Rulesets.Osu.Tests.OsuDifficultyCalculatorTest.Test(Double expectedStarRating, Int32 expectedMaxCombo, String name) in D:\a\osu\osu\osu.Game.Rulesets.Osu.Tests\OsuDifficultyCalculatorTest.cs:line 23
   at InvokeStub_OsuDifficultyCalculatorTest.Test(Object, Span`1)

1)    at osu.Game.Tests.Beatmaps.DifficultyCalculatorTest.Test(Double expectedStarRating, Int32 expectedMaxCombo, String name, Mod[] mods) in D:\a\osu\osu\osu.Game\Tests\Beatmaps\DifficultyCalculatorTest.cs:line 31
   at osu.Game.Rulesets.Osu.Tests.OsuDifficultyCalculatorTest.Test(Double expectedStarRating, Int32 expectedMaxCombo, String name) in D:\a\osu\osu\osu.Game.Rulesets.Osu.Tests\OsuDifficultyCalculatorTest.cs:line 23
   at InvokeStub_OsuDifficultyCalculatorTest.Test(Object, Span`1)

Check failure on line 31 in osu.Game/Tests/Beatmaps/DifficultyCalculatorTest.cs

See this annotation in the file changed.

@github-actions github-actions / Test Results (Windows, SingleThread)

osu.Game.Rulesets.Osu.Tests.OsuDifficultyCalculatorTest ► Test(6.710442985146793d,239,"diffcalc-test") 

Failed test found in:
  TestResults-Windows-SingleThread.trx
Error:
    Expected: 6.710442985146793d +/- 1.0000000000000001E-05d
    But was:  6.7100197470443836d
    Off by:   0.00042323810240940674d
Raw output 
  Expected: 6.710442985146793d +/- 1.0000000000000001E-05d
  But was:  6.7100197470443836d
  Off by:   0.00042323810240940674d

   at osu.Game.Tests.Beatmaps.DifficultyCalculatorTest.Test(Double expectedStarRating, Int32 expectedMaxCombo, String name, Mod[] mods) in D:\a\osu\osu\osu.Game\Tests\Beatmaps\DifficultyCalculatorTest.cs:line 31
   at osu.Game.Rulesets.Osu.Tests.OsuDifficultyCalculatorTest.Test(Double expectedStarRating, Int32 expectedMaxCombo, String name) in D:\a\osu\osu\osu.Game.Rulesets.Osu.Tests\OsuDifficultyCalculatorTest.cs:line 23

1)    at osu.Game.Tests.Beatmaps.DifficultyCalculatorTest.Test(Double expectedStarRating, Int32 expectedMaxCombo, String name, Mod[] mods) in D:\a\osu\osu\osu.Game\Tests\Beatmaps\DifficultyCalculatorTest.cs:line 31
   at osu.Game.Rulesets.Osu.Tests.OsuDifficultyCalculatorTest.Test(Double expectedStarRating, Int32 expectedMaxCombo, String name) in D:\a\osu\osu\osu.Game.Rulesets.Osu.Tests\OsuDifficultyCalculatorTest.cs:line 23

Check failure on line 31 in osu.Game/Tests/Beatmaps/DifficultyCalculatorTest.cs

See this annotation in the file changed.

@github-actions github-actions / Test Results (Windows, SingleThread)

osu.Game.Rulesets.Osu.Tests.OsuDifficultyCalculatorTest ► TestClassicMod(1.4386882251130073d,54,"zero-length-sliders") 

Failed test found in:
  TestResults-Windows-SingleThread.trx
Error:
    Expected: 1.4386882251130073d +/- 1.0000000000000001E-05d
    But was:  1.427174756778619d
    Off by:   0.011513468334388266d
Raw output 
  Expected: 1.4386882251130073d +/- 1.0000000000000001E-05d
  But was:  1.427174756778619d
  Off by:   0.011513468334388266d

   at osu.Game.Tests.Beatmaps.DifficultyCalculatorTest.Test(Double expectedStarRating, Int32 expectedMaxCombo, String name, Mod[] mods) in D:\a\osu\osu\osu.Game\Tests\Beatmaps\DifficultyCalculatorTest.cs:line 31
   at osu.Game.Rulesets.Osu.Tests.OsuDifficultyCalculatorTest.TestClassicMod(Double expectedStarRating, Int32 expectedMaxCombo, String name) in D:\a\osu\osu\osu.Game.Rulesets.Osu.Tests\OsuDifficultyCalculatorTest.cs:line 35
   at InvokeStub_OsuDifficultyCalculatorTest.TestClassicMod(Object, Span`1)

1)    at osu.Game.Tests.Beatmaps.DifficultyCalculatorTest.Test(Double expectedStarRating, Int32 expectedMaxCombo, String name, Mod[] mods) in D:\a\osu\osu\osu.Game\Tests\Beatmaps\DifficultyCalculatorTest.cs:line 31
   at osu.Game.Rulesets.Osu.Tests.OsuDifficultyCalculatorTest.TestClassicMod(Double expectedStarRating, Int32 expectedMaxCombo, String name) in D:\a\osu\osu\osu.Game.Rulesets.Osu.Tests\OsuDifficultyCalculatorTest.cs:line 35
   at InvokeStub_OsuDifficultyCalculatorTest.TestClassicMod(Object, Span`1)

Check failure on line 31 in osu.Game/Tests/Beatmaps/DifficultyCalculatorTest.cs

See this annotation in the file changed.

@github-actions github-actions / Test Results (Windows, SingleThread)

osu.Game.Rulesets.Osu.Tests.OsuDifficultyCalculatorTest ► TestClassicMod(6.710442985146793d,239,"diffcalc-test") 

Failed test found in:
  TestResults-Windows-SingleThread.trx
Error:
    Expected: 6.710442985146793d +/- 1.0000000000000001E-05d
    But was:  6.7100197470443836d
    Off by:   0.00042323810240940674d
Raw output 
  Expected: 6.710442985146793d +/- 1.0000000000000001E-05d
  But was:  6.7100197470443836d
  Off by:   0.00042323810240940674d

   at osu.Game.Tests.Beatmaps.DifficultyCalculatorTest.Test(Double expectedStarRating, Int32 expectedMaxCombo, String name, Mod[] mods) in D:\a\osu\osu\osu.Game\Tests\Beatmaps\DifficultyCalculatorTest.cs:line 31
   at osu.Game.Rulesets.Osu.Tests.OsuDifficultyCalculatorTest.TestClassicMod(Double expectedStarRating, Int32 expectedMaxCombo, String name) in D:\a\osu\osu\osu.Game.Rulesets.Osu.Tests\OsuDifficultyCalculatorTest.cs:line 35

1)    at osu.Game.Tests.Beatmaps.DifficultyCalculatorTest.Test(Double expectedStarRating, Int32 expectedMaxCombo, String name, Mod[] mods) in D:\a\osu\osu\osu.Game\Tests\Beatmaps\DifficultyCalculatorTest.cs:line 31
   at osu.Game.Rulesets.Osu.Tests.OsuDifficultyCalculatorTest.TestClassicMod(Double expectedStarRating, Int32 expectedMaxCombo, String name) in D:\a\osu\osu\osu.Game.Rulesets.Osu.Tests\OsuDifficultyCalculatorTest.cs:line 35

Check failure on line 31 in osu.Game/Tests/Beatmaps/DifficultyCalculatorTest.cs

See this annotation in the file changed.

@github-actions github-actions / Test Results (Windows, SingleThread)

osu.Game.Rulesets.Osu.Tests.OsuDifficultyCalculatorTest ► TestClockRateAdjusted(1.743180218215227d,54,"zero-length-sliders") 

Failed test found in:
  TestResults-Windows-SingleThread.trx
Error:
    Expected: 1.743180218215227d +/- 1.0000000000000001E-05d
    But was:  1.7306397334049743d
    Off by:   0.012540484810252606d
Raw output 
  Expected: 1.743180218215227d +/- 1.0000000000000001E-05d
  But was:  1.7306397334049743d
  Off by:   0.012540484810252606d

   at osu.Game.Tests.Beatmaps.DifficultyCalculatorTest.Test(Double expectedStarRating, Int32 expectedMaxCombo, String name, Mod[] mods) in D:\a\osu\osu\osu.Game\Tests\Beatmaps\DifficultyCalculatorTest.cs:line 31
   at osu.Game.Rulesets.Osu.Tests.OsuDifficultyCalculatorTest.TestClockRateAdjusted(Double expectedStarRating, Int32 expectedMaxCombo, String name) in D:\a\osu\osu\osu.Game.Rulesets.Osu.Tests\OsuDifficultyCalculatorTest.cs:line 29
   at InvokeStub_OsuDifficultyCalculatorTest.TestClockRateAdjusted(Object, Span`1)

1)    at osu.Game.Tests.Beatmaps.DifficultyCalculatorTest.Test(Double expectedStarRating, Int32 expectedMaxCombo, String name, Mod[] mods) in D:\a\osu\osu\osu.Game\Tests\Beatmaps\DifficultyCalculatorTest.cs:line 31
   at osu.Game.Rulesets.Osu.Tests.OsuDifficultyCalculatorTest.TestClockRateAdjusted(Double expectedStarRating, Int32 expectedMaxCombo, String name) in D:\a\osu\osu\osu.Game.Rulesets.Osu.Tests\OsuDifficultyCalculatorTest.cs:line 29
   at InvokeStub_OsuDifficultyCalculatorTest.TestClockRateAdjusted(Object, Span`1)

Check failure on line 31 in osu.Game/Tests/Beatmaps/DifficultyCalculatorTest.cs

See this annotation in the file changed.

@github-actions github-actions / Test Results (Windows, SingleThread)

osu.Game.Rulesets.Osu.Tests.OsuDifficultyCalculatorTest ► TestClockRateAdjusted(8.974295270307167d,239,"diffcalc-test") 

Failed test found in:
  TestResults-Windows-SingleThread.trx
Error:
    Expected: 8.9742952703071666d +/- 1.0000000000000001E-05d
    But was:  8.9727729983409734d
    Off by:   0.001522271966193145d
Raw output 
  Expected: 8.9742952703071666d +/- 1.0000000000000001E-05d
  But was:  8.9727729983409734d
  Off by:   0.001522271966193145d

   at osu.Game.Tests.Beatmaps.DifficultyCalculatorTest.Test(Double expectedStarRating, Int32 expectedMaxCombo, String name, Mod[] mods) in D:\a\osu\osu\osu.Game\Tests\Beatmaps\DifficultyCalculatorTest.cs:line 31
   at osu.Game.Rulesets.Osu.Tests.OsuDifficultyCalculatorTest.TestClockRateAdjusted(Double expectedStarRating, Int32 expectedMaxCombo, String name) in D:\a\osu\osu\osu.Game.Rulesets.Osu.Tests\OsuDifficultyCalculatorTest.cs:line 29

1)    at osu.Game.Tests.Beatmaps.DifficultyCalculatorTest.Test(Double expectedStarRating, Int32 expectedMaxCombo, String name, Mod[] mods) in D:\a\osu\osu\osu.Game\Tests\Beatmaps\DifficultyCalculatorTest.cs:line 31
   at osu.Game.Rulesets.Osu.Tests.OsuDifficultyCalculatorTest.TestClockRateAdjusted(Double expectedStarRating, Int32 expectedMaxCombo, String name) in D:\a\osu\osu\osu.Game.Rulesets.Osu.Tests\OsuDifficultyCalculatorTest.cs:line 29
View more details on GitHub Actions