Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge Discord servers into one article #11929

Merged
merged 44 commits into from
Aug 14, 2024

Conversation

MChecaH
Copy link
Contributor

@MChecaH MChecaH commented Aug 9, 2024

This PR aims to resolve the currently open issue #9934 and close #6904 given the change of direction taken in regards with how Discord Servers are handled in the wiki, both the official osu! server and community servers.

The premise is to simplify everything. Get rid of the individual articles. This will avoid adding redundant information that users can easily find in the servers themselves and reduce the overhead cost required to update the articles in the case the servers are changed.

Self-check

closes #9934 and #6904

@RockRoller01
Copy link
Contributor

RockRoller01 commented Aug 11, 2024

I assume getting rid of socials, websites, etc is part of:

The premise is to simplify everything. [...] This will avoid adding redundant information that users can easily find in the servers themselves and reduce the overhead cost required to update the articles in the case the servers are changed.

?

wiki/Community/Discord_servers/en.md Outdated Show resolved Hide resolved
wiki/Community/Discord_servers/en.md Outdated Show resolved Hide resolved
@MChecaH
Copy link
Contributor Author

MChecaH commented Aug 11, 2024

I assume getting rid of socials, websites, etc is part of:

The premise is to simplify everything. [...] This will avoid adding redundant information that users can easily find in the servers themselves and reduce the overhead cost required to update the articles in the case the servers are changed.

?

Basically get rid of all the information the individual articles provided, which was deemed unnecessary. This is either because users could already be introduced in the servers themselves or because of the information provided was of little to no value given the overhead cost that maintaining the articles supposes.

Copy link
Member

@cl8n cl8n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably have more wording suggestion later i just read through this once and commented on anything that stood out

also, I wasn't going to comment on the selection of servers, but discord.gg/osu seems notably missing as (afaik) the largest general osu server

wiki/Community/Discord_servers/en.md Outdated Show resolved Hide resolved
wiki/Community/Discord_servers/en.md Outdated Show resolved Hide resolved
wiki/Community/Discord_servers/en.md Outdated Show resolved Hide resolved
wiki/Community/Discord_servers/en.md Outdated Show resolved Hide resolved
wiki/Community/Discord_servers/en.md Outdated Show resolved Hide resolved
wiki/Community/Discord_servers/en.md Outdated Show resolved Hide resolved
wiki/Community/Discord_servers/en.md Outdated Show resolved Hide resolved
wiki/Community/Discord_servers/en.md Outdated Show resolved Hide resolved
wiki/Community/Discord_servers/en.md Outdated Show resolved Hide resolved
wiki/Community/Discord_servers/en.md Outdated Show resolved Hide resolved
Co-authored-by: Walavouchey <[email protected]>
@Walavouchey
Copy link
Member

Walavouchey commented Aug 12, 2024

after redirects this is mergeable imo

would also add small images of the server icons to the tables to make them look neater, and add the rest of the servers from the original issue (nvm that's done already)

note this pr deletes the "osu! Discord server" article along with its channel descriptions (just like the other discord articles). i don't particularly mind this change

Question: Is peppy happy with the direction given their dislike of splitting the community further? See #9659 (comment)

i don't think this is relevant to the existence of the article. the "issue" of the community's fragmentation into hundreds of discord servers is a separate discussion

@MChecaH
Copy link
Contributor Author

MChecaH commented Aug 12, 2024

A couple servers still haven't gotten the Okay, which seems like a must according to this comment.

The new servers to add would be two tournament related servers which may warrant a new category and osu! Game, which I took the liberty to add when clayton brought it up.

Adding them, and if they're a no-go we can remove them.

Edit: #6904 (comment) As well

wiki/Community/Discord_servers/en.md Outdated Show resolved Hide resolved
wiki/Community/Discord_servers/en.md Outdated Show resolved Hide resolved
Co-authored-by: Walavouchey <[email protected]>
Copy link
Member

@cl8n cl8n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

last revie w

wiki/Community/Discord_servers/en.md Outdated Show resolved Hide resolved
wiki/Community/Discord_servers/en.md Outdated Show resolved Hide resolved
wiki/Community/Discord_servers/en.md Outdated Show resolved Hide resolved
wiki/Community/Discord_servers/en.md Outdated Show resolved Hide resolved
wiki/Community/Discord_servers/en.md Outdated Show resolved Hide resolved
wiki/Community/Discord_servers/en.md Outdated Show resolved Hide resolved
wiki/Community/Discord_servers/en.md Outdated Show resolved Hide resolved
wiki/Community/Discord_servers/en.md Outdated Show resolved Hide resolved
wiki/Community/Discord_servers/en.md Outdated Show resolved Hide resolved
wiki/Community/Discord_servers/en.md Outdated Show resolved Hide resolved
@cl8n cl8n changed the title Rework Discord servers and osu! Discord server Merge Discord servers into one article Aug 14, 2024
@cl8n cl8n enabled auto-merge August 14, 2024 12:53
@cl8n
Copy link
Member

cl8n commented Aug 14, 2024

thx 💯

@cl8n cl8n merged commit 8f2ff54 into ppy:master Aug 14, 2024
2 of 3 checks passed
@MChecaH MChecaH deleted the MChecaH-discord-servers-rework branch August 14, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
5 participants