Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Countries that participated in osu! tournaments #10800

Merged
merged 12 commits into from
Aug 12, 2024

Conversation

iSlodinxOsu
Copy link
Contributor

@iSlodinxOsu iSlodinxOsu commented Jan 16, 2024

Self-check

Feel free to comment something if i mess something up.

Copy link
Member

@Walavouchey Walavouchey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should probably update the comment on line 10

@iSlodinxOsu
Copy link
Contributor Author

Will update the translations once i have time.

@iSlodinxOsu iSlodinxOsu marked this pull request as draft February 29, 2024 23:09
@cl8n cl8n force-pushed the tournament-participations branch from 783c086 to 1226040 Compare August 11, 2024 07:26
@cl8n cl8n self-assigned this Aug 12, 2024
@cl8n cl8n force-pushed the tournament-participations branch from 1226040 to d6a852b Compare August 12, 2024 07:42
@cl8n cl8n marked this pull request as ready for review August 12, 2024 07:43
@cl8n
Copy link
Member

cl8n commented Aug 12, 2024

well I will be honest I didn't check all of the data because this seems like a nightmare. I did add a column for MWC 2022 4K, which was missing. this is probably a just-automate-it type of page if we want to keep supporting it

as for the translations, I did just automate them (osu-wiki translate-tournament-countries), it should hold up for at least the most basic edits to this page like adding new tournaments

@cl8n cl8n enabled auto-merge August 12, 2024 08:46
@cl8n cl8n merged commit bc5b2e1 into ppy:master Aug 12, 2024
2 checks passed
@iSlodinxOsu iSlodinxOsu deleted the tournament-participations branch August 15, 2024 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants