Clean up authorize assertions #11656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
nanaya
commented
Nov 15, 2024
nanaya
commented
- reject null user in some cases
- don't return anything
- reject null user in some cases - don't return anything
notbakaneko
requested changes
Nov 18, 2024
app/Singletons/OsuAuthorize.php
Outdated
| if ($user->isRestricted()) { | ||
| throw new AuthorizationCheckException($prefix.'restricted'); | ||
| } | ||
|
|
||
| if ($user->isSilenced()) { | ||
| throw new AuthorizationCheckException($prefix.'silenced'); | ||
| } | ||
|
|
||
| return 'ok'; | ||
| } | ||
|
|
||
| /** | ||
| * @param User|null $user |
There was a problem hiding this comment.
also needs updating, or just removed since it's not adding any new info, same with the other one
nanaya
force-pushed
the
auth-check-cleanup
branch
from
a3561ab
to
2886b1c
Compare
notbakaneko
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.