Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add helper command for getting Shopify-related checkout details #11511

Merged
merged 3 commits into from
Sep 27, 2024

Conversation

notbakaneko
Copy link
Collaborator

Mainly to get the Shopify order orderNumber or id.
It calls the public Storefront API so it can use the same token instead of needed a separate oauth client/secret for the admin API.
API version is matched to the current shopify-buy sdk's version (and different version has different schema and I don't feel like updating it now)

@notbakaneko notbakaneko self-assigned this Sep 26, 2024
@peppy
Copy link
Member

peppy commented Sep 27, 2024

Do you think it would be feasible to store these at some point in the checkout process to the database? This would allow for easier lookups from external tooling.

@notbakaneko
Copy link
Collaborator Author

That's part of the plan.
The current public token is also rate-limited by IP which normally isn't a problem during checkout since they're initiated from the user's end;

Copy link
Collaborator

@nanaya nanaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a lot of things for what should be just storing order_number during the webhook callback or something 🤔 I guess it's useful for checking existing orders

@nanaya nanaya merged commit de0db22 into ppy:master Sep 27, 2024
3 checks passed
@notbakaneko notbakaneko deleted the feature/shopify-php branch September 27, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants