Skip to content

Refactor GetMaxCombo #245

Refactor GetMaxCombo

Refactor GetMaxCombo #245

Triggered via pull request October 25, 2024 21:08
Status Failure
Total duration 1m 32s
Artifacts

ci.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

3 errors, 1 warning, and 10 notices
Code Quality: PerformanceCalculator/Simulate/TaikoSimulateCommand.cs#L6
Using directive is not required by the code and can be safely removed in PerformanceCalculator\Simulate\TaikoSimulateCommand.cs on line 6
Code Quality: PerformanceCalculator/Simulate/TaikoSimulateCommand.cs#L13
Using directive is not required by the code and can be safely removed in PerformanceCalculator\Simulate\TaikoSimulateCommand.cs on line 13
Code Quality
Process completed with exit code 5.
Code Quality
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/setup-dotnet@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Code Quality: PerformanceCalculator/Performance/ReplayPerformanceCommand.cs#L76
Convert into primary constructor in PerformanceCalculator\Performance\ReplayPerformanceCommand.cs on line 76
Code Quality: PerformanceCalculator/ProcessorScoreDecoder.cs#L19
Convert into primary constructor in PerformanceCalculator\ProcessorScoreDecoder.cs on line 19
Code Quality: PerformanceCalculatorGUI/APIManager.cs#L28
Convert into primary constructor in PerformanceCalculatorGUI\APIManager.cs on line 28
Code Quality: PerformanceCalculatorGUI/Components/ExtendedOsuFileSelector.cs#L27
Convert into primary constructor in PerformanceCalculatorGUI\Components\ExtendedOsuFileSelector.cs on line 27
Code Quality: PerformanceCalculatorGUI/Components/ExtendedOsuFileSelector.cs#L52
Convert into primary constructor in PerformanceCalculatorGUI\Components\ExtendedOsuFileSelector.cs on line 52
Code Quality: PerformanceCalculatorGUI/Components/ExtendedProfileScore.cs#L43
Convert into primary constructor in PerformanceCalculatorGUI\Components\ExtendedProfileScore.cs on line 43
Code Quality: PerformanceCalculatorGUI/Components/ExtendedUserModSelectOverlay.cs#L12
Convert into primary constructor in PerformanceCalculatorGUI\Components\ExtendedUserModSelectOverlay.cs on line 12
Code Quality: PerformanceCalculatorGUI/Components/LeaderboardTable.cs#L34
Use collection expression in PerformanceCalculatorGUI\Components\LeaderboardTable.cs on line 34
Code Quality: PerformanceCalculatorGUI/Components/LeaderboardTable.cs#L50
Use collection expression in PerformanceCalculatorGUI\Components\LeaderboardTable.cs on line 50
Code Quality: PerformanceCalculatorGUI/Components/LeaderboardTable.cs#L97
Convert into primary constructor in PerformanceCalculatorGUI\Components\LeaderboardTable.cs on line 97