Fix pack pass check considering converted plays when pack is not associated with a ruleset #277
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reported privately.
The corresponding web-10 query looks like this (somewhat abridged):
If it is not immediately clear why the above disallows converts, then to spell it out: it is the part that the query is split into four
UNION
'd parts, each of which queries only onescores_high
table for each of the rulesets, and only includes the beatmaps in the pack which have the sameplaymode
.For profiling purposes, here are two examples of query shapes after this change, taken from the test (params may need tweaking appropriately):