👷 Trigger remote tag and build on private repo #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdach
reviewed
Apr 11, 2024
Comment on lines
+87
to
+89
| - | ||
| name: Checkout | ||
| uses: actions/checkout@v4 |
There was a problem hiding this comment.
Is this doing anything? It feels unnecessary, if the ref name is in the github context already I don't think this job needs the source for anything anymore?
There was a problem hiding this comment.
Yeah, that irks me a little as well. It's in every other project with this kind of workflow in the org and I'm not sure why. Not sure this is necessary to action on since I plan to overhaul all the deployment processes to get rid of most plumbing on the private side.
peppy
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@peppy Manual approval for deployments to the
productionenvironment can be set up in this project's settings, similar toosu-web.